After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786254 - Use new app icon name for .desktop
Use new app icon name for .desktop
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.25.x
Other All
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-13 21:14 UTC by Jeremy Bicha
Modified: 2017-08-20 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use new app icon name for .desktop (972 bytes, patch)
2017-08-13 21:14 UTC, Jeremy Bicha 		none Details | Review
Use new app icon (3.10 KB, patch)
2017-08-14 00:12 UTC, Jeremy Bicha 		none Details | Review

Description Jeremy Bicha 2017-08-13 21:14:12 UTC 
Follow up from
https://git.gnome.org/browse/gnome-contacts/commit/?id=e1c2ab029
Comment 1 Jeremy Bicha 2017-08-13 21:14:15 UTC 
Created attachment 357528 [details] [review]
Use new app icon name for .desktop
Comment 2 Jeremy Bicha 2017-08-14 00:12:32 UTC 
Created attachment 357535 [details] [review]
Use new app icon

And this patch uses the new icon elsewhere in the program.

This change is most noticable with Ubuntu 17.10 with the default icons, where Ubuntu uses a brown version of x-office-address-book

(Of course nothing stops Ubuntu from symlinking that icon to represent 'gnome-contacts' too).
Comment 3 Niels De Graef 2017-08-20 14:52:54 UTC 
Was a bit hesitant to push this since we're past the UI freeze, but I guess this is a case of making the icon consistent, rather than changing the UI.

Landed as
* commit 71677f1c10aa95bbf5405e24695915ad15e65bf4 (desktop file)
* commit 633b4025b9187d92057a4214dfca56b2cc5a7def (other)
Comment 4 Niels De Graef 2017-08-20 14:54:17 UTC 
Btw, thanks for the patches!