After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786078 - compositor / videoaggregator: some performance improvements
compositor / videoaggregator: some performance improvements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-10 00:33 UTC by Mathieu Duponchelle
Modified: 2017-08-10 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compositor: improve conversion debugging (1.36 KB, patch)
2017-08-10 00:34 UTC, Mathieu Duponchelle 		committed Details | Review
videoaggregator: improve find_best_format heuristic. (1.21 KB, patch)
2017-08-10 00:34 UTC, Mathieu Duponchelle 		committed Details | Review
videoaggregator: use colorimetry from find_best_format. (1.66 KB, patch)
2017-08-10 00:34 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-08-10 00:33:56 UTC 
This makes the heuristic for picking the target format a bit less naive,
and also spares us conversion altogether for simple cases, by picking
a colorimetry.
Comment 1 Mathieu Duponchelle 2017-08-10 00:34:01 UTC 
Created attachment 357312 [details] [review]
compositor: improve conversion debugging
Comment 2 Mathieu Duponchelle 2017-08-10 00:34:05 UTC 
Created attachment 357313 [details] [review]
videoaggregator: improve find_best_format heuristic.

The goal here is to minimize the work needed to bring all images
to a common format. A better criteria than the number of pads
with a given format is the number of pixels with a given format.
Comment 3 Mathieu Duponchelle 2017-08-10 00:34:10 UTC 
Created attachment 357314 [details] [review]
videoaggregator: use colorimetry from find_best_format.

This increases the chances that we won't need to do any conversion
for a given pad.
Comment 4 Thibault Saunier 2017-08-10 01:42:54 UTC 
Review of attachment 357313 [details] [review]:

Sounds good.
Comment 5 Thibault Saunier 2017-08-10 01:44:32 UTC 
Review of attachment 357312 [details] [review]:

lgtm
Comment 6 Mathieu Duponchelle 2017-08-10 11:56:49 UTC 
Attachment 357312 [details] pushed as 29c4ecb - compositor: improve conversion debugging
Attachment 357313 [details] pushed as 388b7ee - videoaggregator: improve find_best_format heuristic.
Attachment 357314 [details] pushed as ca8d5f2 - videoaggregator: use colorimetry from find_best_format.