After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786042 - general: load fallback file icon from resources
general: load fallback file icon from resources
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-09 11:00 UTC by Ernestas Kulik
Modified: 2017-08-09 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
general: load fallback file icon from resources (45.95 KB, patch)
2017-08-09 11:00 UTC, Ernestas Kulik 		none Details | Review
general: load fallback file icon from resources (45.91 KB, patch)
2017-08-09 11:03 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-08-09 11:00:33 UTC 
The fallback file icon is outdated now and the fact that it is stored in
binary format in a source file makes it harder to update it. This commit
uses the upstream PNG and changes the code to load it from resources.
Comment 1 Ernestas Kulik 2017-08-09 11:00:39 UTC 
Created attachment 357250 [details] [review]
general: load fallback file icon from resources
Comment 2 Ernestas Kulik 2017-08-09 11:03:11 UTC 
Created attachment 357251 [details] [review]
general: load fallback file icon from resources

The fallback file icon is outdated now and the fact that it is stored in
binary format in a source file makes it harder to update it. This commit
uses the upstream PNG and changes the code to load it from resources.
Comment 3 Carlos Soriano 2017-08-09 11:49:37 UTC 
Review of attachment 357251 [details] [review]:

Good bye :( :( :( :( :(
Comment 4 Ernestas Kulik 2017-08-09 13:38:33 UTC 
Attachment 357251 [details] pushed as 366f003 - general: load fallback file icon from resources