After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785793 - gsk_color_matrix_node_draw leaking cairo_pattern_t
gsk_color_matrix_node_draw leaking cairo_pattern_t
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Scene Graph
3.91.x
Other Windows
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-08-03 23:16 UTC by Marc Micalizzi
Modified: 2017-08-04 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gskrendernodeimpl: Fix leak of Cairo Pattern (729 bytes, patch)
2017-08-03 23:19 UTC, Daniel Boles
committed Details | Review

Description Marc Micalizzi 2017-08-03 23:16:20 UTC
gsk_color_matrix_node_draw() never calls cairo_pattern_destroy() on the pattern returned from cairo_pop_group(), resulting in a memory leak leading to (at least on win32) regular crashes

this is with gtk+ git head as on 8/3/2017
Comment 1 Daniel Boles 2017-08-03 23:19:15 UTC
Created attachment 356905 [details] [review]
gskrendernodeimpl: Fix leak of Cairo Pattern