After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785762 - comics: Prevent return of uninitialised variable
comics: Prevent return of uninitialised variable
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: comics
git master
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-03 08:19 UTC by astian
Modified: 2017-08-05 06:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
comics: Prevent return of uninitialised variable (1.07 KB, patch)
2017-08-03 08:19 UTC, astian 		none Details | Review
comics: Prevent return of uninitialised variable (1.12 KB, patch)
2017-08-03 15:06 UTC, astian 		committed Details | Review

Description astian 2017-08-03 08:19:00 UTC 
Created attachment 356826 [details] [review]
comics: Prevent return of uninitialised variable

GCC is right:
  backend/comics/comics-document.c: In function ‘comics_document_list’:
  backend/comics/comics-document.c:155:9: warning: ‘array’ may be used
  uninitialized in this function [-Wmaybe-uninitialized]
    return array;
           ^~~~~

This is an actual bug.
Comment 1 astian 2017-08-03 15:06:54 UTC 
Created attachment 356861 [details] [review]
comics: Prevent return of uninitialised variable
Comment 2 Carlos Garcia Campos 2017-08-05 06:51:16 UTC 
Comment on attachment 356861 [details] [review]
comics: Prevent return of uninitialised variable

Right, pushed.