After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785623 - omx: also reset nFilledLen before calling OMX_FillThisBuffer()
omx: also reset nFilledLen before calling OMX_FillThisBuffer()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal minor
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-31 10:51 UTC by Guillaume Desmottes
Modified: 2017-08-01 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omx: also reset nFilledLen before calling OMX_FillThisBuffer() (1.18 KB, patch)
2017-07-31 10:52 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-07-31 10:51:47 UTC 
.
Comment 1 Guillaume Desmottes 2017-07-31 10:52:15 UTC 
Created attachment 356632 [details] [review]
omx: also reset nFilledLen before calling OMX_FillThisBuffer()

The spec states that the buffer passed to OMX_FillThisBuffer() needs to be
empty. Some implementation may check it actually is by checking its
nFilledLen field, so best to reset it as well.
Comment 2 Nicolas Dufresne (ndufresne) 2017-07-31 13:53:34 UTC 
Review of attachment 356632 [details] [review]:

Make sense.
Comment 3 Nicolas Dufresne (ndufresne) 2017-08-01 15:26:18 UTC 
Attachment 356632 [details] pushed as 7a0949b - omx: also reset nFilledLen before calling OMX_FillThisBuffer()