After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785612 - gthumb slideshow extension trying to use non-existent gsettingsaudiosink as playbin audio-sink
gthumb slideshow extension trying to use non-existent gsettingsaudiosink as p...
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2017-07-31 02:41 UTC by Mart Raudsepp
Modified: 2017-07-31 08:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Mart Raudsepp 2017-07-31 02:41:06 UTC 
extensions/slideshow/gth-slideshow.c does

g_object_set (self->priv->playbin,
      "audio-sink", gst_element_factory_make ("gsettingsaudiosink", "audiosink"),
      "flags", _GST_PLAY_FLAG_AUDIO,
      "volume", 1.0,
      NULL);

But gsettingsaudiosink isn't a thing in gstreamer-1.0+.

No idea what the effect of it to the slideshow extension is though, but this code is in both 3.4 branch and master.
Comment 1 Paolo Bacchilega 2017-07-31 06:09:41 UTC 
(In reply to Mart Raudsepp from comment #0)
> extensions/slideshow/gth-slideshow.c does
> 
> g_object_set (self->priv->playbin,
>       "audio-sink", gst_element_factory_make ("gsettingsaudiosink",
> "audiosink"),
>       "flags", _GST_PLAY_FLAG_AUDIO,
>       "volume", 1.0,
>       NULL);
> 
> But gsettingsaudiosink isn't a thing in gstreamer-1.0+.

replaced with autoaudiosink

> 
> No idea what the effect of it to the slideshow extension is though, but this
> code is in both 3.4 branch and master.

in the catalog properties you can specify a series of audio files to play during a slideshow.
Comment 2 Mart Raudsepp 2017-07-31 06:34:03 UTC 
Then there should be no reason to set any - that's generally the default, unless gst-plugins-base gets built with a different --with-default-audiosink=...; but in this case you probably want to honor that in gthumb as well, via not overriding it.
Comment 3 Paolo Bacchilega 2017-07-31 08:50:46 UTC 
(In reply to Mart Raudsepp from comment #2)
> Then there should be no reason to set any - that's generally the default,
> unless gst-plugins-base gets built with a different
> --with-default-audiosink=...; but in this case you probably want to honor
> that in gthumb as well, via not overriding it.

ok, thank you.