After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785545 - add '--version' option to gnome-tweaks CLI
add '--version' option to gnome-tweaks CLI
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-07-28 21:21 UTC by Alexander Rüedlinger (lexruee)
Modified: 2017-07-28 22:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add '--version' option to gnome-tweaks CLI (1.34 KB, patch)
2017-07-28 21:21 UTC, Alexander Rüedlinger (lexruee) 		committed Details | Review

Description Alexander Rüedlinger (lexruee) 2017-07-28 21:21:34 UTC 
Created attachment 356533 [details] [review]
add '--version' option to gnome-tweaks CLI

In my opinion, it would a good idea to add a '--version' option to the GNOME tweaks CLI so that it follows the GNU Coding Standards [1].

Thanks to the optparse library [2], this can be easily fixed by passing a version argument to OptionParser.

[1] https://www.gnu.org/prep/standards/html_node/Command_002dLine-Interfaces.html
[2] https://docs.python.org/3.5/library/optparse.html#printing-a-version-string
Comment 1 Alexander Rüedlinger (lexruee) 2017-07-28 21:30:59 UTC 
See the attached patch file for more details.
Comment 2 Jeremy Bicha 2017-07-28 21:47:39 UTC 
Review of attachment 356533 [details] [review]:

Thanks!

Let me know if you need me to push this to the git repo for you.
Comment 3 Alexander Rüedlinger (lexruee) 2017-07-28 21:54:26 UTC 
Hi Jeremy.
I'm a new contributor to GNOME so I have no git access the repository :-).
Feel free to push it to the repository :-).
Comment 4 Jeremy Bicha 2017-07-28 22:32:58 UTC 
Welcome to GNOME!

I tweaked the commit message slightly and pushed for you.

Attachment 356533 [details] pushed as 3c6aa1b - add '--version' option to gnome-tweaks CLI