After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785397 - 3.25.91: Search panel doesn't shrink horizontally well
3.25.91: Search panel doesn't shrink horizontally well
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Search
git master
Other Linux
: Normal normal
: ---
Assigned To: Cosimo Cecchi
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-25 11:49 UTC by Jeremy Bicha
Modified: 2017-08-28 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
search: don't allow horizontal scrolling (905 bytes, patch)
2017-08-28 10:27 UTC, Jonathan Kang
committed Details | Review

Description Jeremy Bicha 2017-07-25 11:49:37 UTC
gnome-control-center 1:3.25.4-0ubuntu0~artful2 from the GNOME3 Staging PPA
Ubuntu 17.10 Alpha

In the new "gnome-control-center-alt", the Search panel doesn't shrink horizontally very well.

When shrunk to the minimum width, there is a fairly wide margin on the left and the On/Off switches are no longer visible. A horizontal scrollbar is added. (If you scroll to the right, you can see the On/Off switch and a fairly wide margin on the right too.)

I think we want to not have a horizontal scrollbar and reduce the left and right margins when the panel is shrunk to minimal width.
Comment 1 Jeremy Bicha 2017-08-25 15:23:03 UTC
Tested with 3.25.91. The margin doesn't seem too wide to me on the left or right now, but the horizontal scrolling is still a problem.
Comment 2 Jonathan Kang 2017-08-28 10:27:25 UTC
Created attachment 358579 [details] [review]
search: don't allow horizontal scrolling

Set hscrollbar_policy property of GtkScrolledWindow to never to
disable horizontal scrolling.
Comment 3 Rui Matos 2017-08-28 16:52:12 UTC
Review of attachment 358579 [details] [review]:

ok
Comment 4 Rui Matos 2017-08-28 17:01:00 UTC
I'm pushing a further fix on top to set a minimum size too.

Attachment 358579 [details] pushed as a108ee1 - search: don't allow horizontal scrolling