GNOME Bugzilla – Bug 785323
Sidebar visibility setting should be persistent
Last modified: 2017-08-17 13:59:03 UTC
Forwarding from https://bugs.debian.org/869269 ---------- The sidebar (inactive) option between sessions is not maintained * What led to the situation? Uncheck sidebar via "Preferences" from the nautilus menu. During the session the configuration is maintained, but in the next session that starts, the sidebar reappears. * What exactly did (or did not) do that was effective ineffective)? Override the sidebar through the nautilus "preferences" menu. Standard user. * What was the result of this action? The sidebar remains hidden during the session. * What result did you expect instead? When you re-open session on the same user perform the view configuration without sidebar in the nautilus windows. ---------- I can confirm that on Debian with nautilus version 3.22.3-1, changing the Sidebar option in the AppMenu does not save this setting to dconf and closing and relaunching nautilus does not remember the state of the sidebar. I think it would make sense for the sidebar visibility setting to persist.
Created attachment 356247 [details] [review] Save-sidebar-visibility-state.patch This patch saves the sidebar state to the "start-with-sidebar" key whenever the sidebar visibility changes. Though there are more complicated ways this could be done such as with g_settings_bind_with_mapping.
Review of attachment 356247 [details] [review]: Hey Jason, thanks for your work! I definitely like your proposal for using g_settings_bind_with_mapping, could you?
Created attachment 357605 [details] [review] Save-sidebar-visibility-state.patch [g_settings_bind_with_mapping] (In reply to Carlos Soriano from comment #2) > I definitely like your proposal for using g_settings_bind_with_mapping, > could you? This patch uses g_settings_bind_with_mapping to save the sidebar state. This listens for GAction's notify::state signal instead of using the change_state callback because the callback is not called when 'bind' changes the state.
Review of attachment 357605 [details] [review]: Looks good, thanks!!