After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785294 - tracker-miner.pc.in still references @LIBTRACKER_MINER_PC_REQUIRES@
tracker-miner.pc.in still references @LIBTRACKER_MINER_PC_REQUIRES@
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Miners
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-07-23 01:32 UTC by Michael Biebl
Modified: 2017-07-23 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PATCH] Remove leftover @LIBTRACKER_MINER_PC_REQUIRES@ from tracker-miner.pc.in (1009 bytes, patch)
2017-07-23 16:58 UTC, Michael Biebl 		accepted-commit_now Details | Review

Description Michael Biebl 2017-07-23 01:32:07 UTC 
In git master the libmediaart code was removed in ac84484dfb5dea636e4b2e830d25901413fb970c but
src/libtracker-miner/tracker-miner.pc.in still has some left over bits

Requires.priv: @LIBTRACKER_MINER_PC_REQUIRES@

That line should be dropped, as otherwise you get an invalid .pc file like this

$ cat src/libtracker-miner/tracker-miner-2.0.pc
prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib/x86_64-linux-gnu
includedir=${prefix}/include

Name: tracker-miner
Description: A library to develop tracker data miners
Version: 1.99.1
Requires: glib-2.0 gio-2.0 tracker-sparql-2.0
Requires.priv: @LIBTRACKER_MINER_PC_REQUIRES@
Libs: -L${libdir} -ltracker-miner-2.0
Cflags: -I${includedir}/tracker-2.0
Comment 1 Michael Biebl 2017-07-23 16:58:38 UTC 
Created attachment 356236 [details] [review]
PATCH] Remove leftover @LIBTRACKER_MINER_PC_REQUIRES@ from  tracker-miner.pc.in
Comment 2 Carlos Garnacho 2017-07-23 20:01:57 UTC 
Comment on attachment 356236 [details] [review]
PATCH] Remove leftover @LIBTRACKER_MINER_PC_REQUIRES@ from  tracker-miner.pc.in

Oops. Thanks for spotting
Comment 3 Michael Biebl 2017-07-23 20:15:24 UTC 
Committed as d0049aeb9c6958ec87561d2a4ac263bd70dce901