GNOME Bugzilla – Bug 785279
[PATCH] GXml.DomNonDocumentTypeChildNode : make properties 'owned'
Last modified: 2017-09-04 15:54:18 UTC
Created attachment 356186 [details] [review] [PATCH] GXml.DomNonDocumentTypeChildNode : make properties 'owned' if properties aren't 'owned', returned values are NULL, or errors are thrown during object cast.
Review of attachment 356186 [details] [review]: Please file a separate bug report for your changes and update your patch. This bug's patch should include just "owned" added to interfaces. Second bug report should patch and, if possible, a test case for patched previous_element_sibling(), next_element_sibling() G's and Gom's implementations. Thanks for your help.
I've locally patched my tree, but found some issues while writting a test case, so tried to use Xml.Node.previous_element_sibling()/next_element_sibling(), but the first one is missing in libmxl2 bindings, so it need to be added. So filed bug #787201.
Created attachment 359010 [details] [review] previous/next element sibling using libxml2 for GChildNode While this is marking your patch as obsolete, it is an extension for it, so you will see your contribution in the log when fixed this bug and bug #787201. May you want to help me adding test case for GomChildNode/GomElement, may using the one included in this patch. Found we need to add more test cases and add more owned get in other interfaces returning new elements, specially for libxml2 bindings (GNode derived classes).
This bug have been fixed and tested at: https://git.gnome.org/browse/gxml/commit/?id=7c8a5668e0c301e1c5e54fe8002c35200bcd22c1