After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785125 - omxvideoenc/dec: declare latency on zynqultrascaleplus
omxvideoenc/dec: declare latency on zynqultrascaleplus
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-19 13:19 UTC by Guillaume Desmottes
Modified: 2017-08-10 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideoenc/dec: declare latency on zynqultrascaleplus (5.63 KB, patch)
2017-07-19 13:19 UTC, Guillaume Desmottes 		none Details | Review
omxvideoenc/dec: declare latency on zynqultrascaleplus (3.61 KB, patch)
2017-08-04 22:38 UTC, Guillaume Desmottes 		none Details | Review
omxvideoenc/dec: declare latency on zynqultrascaleplus (3.52 KB, patch)
2017-08-09 21:00 UTC, Guillaume Desmottes 		committed Details | Review
omxvideodec: use the decoder API to set latency (835 bytes, patch)
2017-08-10 17:22 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-07-19 13:19:32 UTC 
.
Comment 1 Guillaume Desmottes 2017-07-19 13:19:47 UTC 
Created attachment 355947 [details] [review]
omxvideoenc/dec: declare latency on zynqultrascaleplus

The OMX specification doesn't provide any API to expose the latency
introduced by encoders and decoders. We implemented this as a custom
extension as declaring the latency is needed for live pipelines like
video conferencing.
Comment 2 Guillaume Desmottes 2017-07-21 07:58:38 UTC 
Comment on attachment 355947 [details] [review]
omxvideoenc/dec: declare latency on zynqultrascaleplus

We are considering to improve this OMX API. Let's hold on for now.
Comment 3 Guillaume Desmottes 2017-08-04 22:38:00 UTC 
Created attachment 356986 [details] [review]
omxvideoenc/dec: declare latency on zynqultrascaleplus

The OMX specification doesn't provide any API to expose the latency
introduced by encoders and decoders. We implemented this as a custom
extension as declaring the latency is needed for live pipelines like
video conferencing.
Comment 4 Nicolas Dufresne (ndufresne) 2017-08-09 20:55:31 UTC 
Review of attachment 356986 [details] [review]:

Looks good, quite HW specific, but someone could reuse the OMX extension, which seems simple enough.
Comment 5 Nicolas Dufresne (ndufresne) 2017-08-09 20:57:20 UTC 
A rebase would be nice, so I don't screwup.
Comment 6 Guillaume Desmottes 2017-08-09 21:00:45 UTC 
Created attachment 357306 [details] [review]
omxvideoenc/dec: declare latency on zynqultrascaleplus

The OMX specification doesn't provide any API to expose the latency
introduced by encoders and decoders. We implemented this as a custom
extension as declaring the latency is needed for live pipelines like
video conferencing.
Comment 7 Nicolas Dufresne (ndufresne) 2017-08-09 21:01:39 UTC 
Attachment 357306 [details] pushed as f2b0b66 - omxvideoenc/dec: declare latency on zynqultrascaleplus
Comment 8 Guillaume Desmottes 2017-08-10 17:22:39 UTC 
Oops looks like I got my code mixed up. Sorry about that.
Comment 9 Guillaume Desmottes 2017-08-10 17:22:56 UTC 
Created attachment 357344 [details] [review]
omxvideodec: use the decoder API to set latency
Comment 10 Nicolas Dufresne (ndufresne) 2017-08-10 18:03:01 UTC 
Review of attachment 357344 [details] [review]:

commit 6d2082003acf587bc051dbe3ddf9fad57f7e8fb9 (HEAD -> master, origin/master, origin/HEAD)
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Aug 10 12:16:53 2017 -0400

    omxvideodec: use the decoder API to set latency
    
    https://bugzilla.gnome.org/show_bug.cgi?id=785125