After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785100 - Typo in warning message
Typo in warning message
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-19 04:40 UTC by Mohammed Sadiq
Modified: 2017-08-18 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the typo (1.53 KB, patch)
2017-07-20 03:52 UTC, Scott Cohen 		none Details | Review
This reiterates the commit message in the previous version of the patch. (1.36 KB, patch)
2017-08-17 21:06 UTC, Scott Cohen 		committed Details | Review

Description Mohammed Sadiq 2017-07-19 04:40:16 UTC 
connection is typod as conneciton

panels/network/connection-editor/net-connection-editor.c:860: g_warning ("Failed to delete conneciton %s: %s",
Comment 1 Scott Cohen 2017-07-20 03:52:20 UTC 
Created attachment 356004 [details] [review]
Fixes the typo
Comment 2 Mohammed Sadiq 2017-08-16 07:20:50 UTC 
Review of attachment 356004 [details] [review]:

Hi. 

The code looks good. The commit message can have improvement though.

You can remove redundant words from subject. Say for example:
net-connection-editor: Fix typo in error message

The detailed body doesn't require to be that detailed. It can be simplified to something like:

replace "conneciton" with "connection"

or

fix typo in "connection"

or something like that.

Thanks
Comment 3 Scott Cohen 2017-08-17 21:06:42 UTC 
Created attachment 357840 [details] [review]
This reiterates the commit message in the previous version of the patch.

Sorry, when I filed another patch for something else, someone told me to say what and why instead of just what and other bug writing etiquette and I didn't want a repeat of that.
Comment 4 Georges Basile Stavracas Neto 2017-08-18 14:29:08 UTC 
Review of attachment 357840 [details] [review]:

LGTM
Comment 5 Georges Basile Stavracas Neto 2017-08-18 14:37:56 UTC 
Thanks for your patch! Pushed with a minor adjustment in the commit message.

Attachment 357840 [details] pushed as 87c69ed955 - network: Fix typo in error message