GNOME Bugzilla – Bug 785090
workspace: Use has_pointer() method instead of property
Last modified: 2017-07-22 18:33:02 UTC
Looks like some more fallout from the recent gjs update. I'll ask Philip whether the behavior change is intentional, but in any case the patch doesn't hurt.
Created attachment 355901 [details] [review] workspace: Use has_pointer() method instead of property ClutterActor has both a has_pointer() method and a :has-pointer property (that we represent as 'has_pointer'). So far gjs was able to deal with the name overlap, but now trying to use the property will instead test for the availability of the method. Just avoid the conflict by switching to the method, which is unambiguous.
Review of attachment 355901 [details] [review]: ok
Attachment 355901 [details] pushed as 6878ee9 - workspace: Use has_pointer() method instead of property
Sigh, this worked less well than I thought :-(
Created attachment 356163 [details] [review] workspace: Switch back to using the :has-pointer property In case where a method- and property name overlap, using the method is less unambiguous than I thought - mozjs52-based gjs will only see the method, while mozjs38-based gjs will only see the property. We are in luck though, and the real property name contains dashes that allow us to refer to the property in a way that works for all gjs versions.
Review of attachment 356163 [details] [review]: guess I didn't open up the overview while trying the previous one
Attachment 356163 [details] pushed as 734511a - workspace: Switch back to using the :has-pointer property