After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784965 - Use the glib preset for i18n in Meson
Use the glib preset for i18n in Meson
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.53.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-07-15 01:42 UTC by Piotr Drąg
Modified: 2017-07-25 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the glib preset for i18n in Meson (2.27 KB, patch)
2017-07-15 01:42 UTC, Piotr Drąg 		none Details | Review
Use the glib preset for i18n in Meson (2.35 KB, patch)
2017-07-25 15:33 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2017-07-15 01:42:10 UTC 
Since 0.37, meson supports a glib preset to handle i18n details.
Comment 1 Piotr Drąg 2017-07-15 01:42:56 UTC 
Created attachment 355666 [details] [review]
Use the glib preset for i18n in Meson
Comment 2 Christoph Reiter (lazka) 2017-07-22 07:01:33 UTC 
Review of attachment 355666 [details] [review]:

lgtm, for what it's worth
Comment 3 Matthias Clasen 2017-07-25 15:01:46 UTC 
Review of attachment 355666 [details] [review]:

The patch actually does two things: 
1) use the preset for the xgettext options
2) rely on meson to parse LINGUAS
Would be good to mention both in the commit message
Comment 4 Piotr Drąg 2017-07-25 15:33:38 UTC 
Created attachment 356367 [details] [review]
Use the glib preset for i18n in Meson

Does that work?
Comment 5 Matthias Clasen 2017-07-25 16:43:38 UTC 
Review of attachment 356367 [details] [review]:

sure
Comment 6 Piotr Drąg 2017-07-25 16:58:01 UTC 
Comment on attachment 356367 [details] [review]
Use the glib preset for i18n in Meson

Thank you!

https://git.gnome.org/browse/glib/commit/?id=528a1b9288e410f961b012c75d4887da3ad15b2e