Created attachment 355581 [details] [review]
decklink: Add autotools support on Windows

Also add a missing windows file to EXTRA_DIST

I've tested this on cross-win64 inside Cerbero, and it seems to build and install just fine for me. Do you think you can test it, Felipe?

Comment on attachment 355581 [details] [review]
decklink: Add autotools support on Windows

Now this only needs cerbero changes

Created attachment 355586 [details] [review]
recipes: Enable decklink in gst-plugins-bad on Windows

Comment on attachment 355581 [details] [review]
decklink: Add autotools support on Windows

Attachment 355581 [details] pushed as 528ae2c - decklink: Add autotools support on Windows

Attachment 355586 [details] pushed as 563793f - recipes: Enable decklink in gst-plugins-bad on Windows

It builds great, I can't test the dll right now because I don't have the card with me right know, I will check on Monday but I am sure it will work fine.

Thanks for the fix, bug is closed for me, thanks a lot!!

Seems like this change breaks the msys2/mingw build.


libtool: compile:  i686-w64-mingw32-g++ -DHAVE_CONFIG_H -I. -I../../../gst-plugins-bad/sys/decklink -I../.. -I../../../gst-plugins-bad/gst-libs -I../../gst-libs -pthread -mms-bitfields -ID:/msys64/mingw32/include/gstreamer-1.0 -ID:/msys64/mingw32/include/glib-2.0 -ID:/msys64/mingw32/lib/glib-2.0/include -ID:/msys64/mingw32/include -pthread -mms-bitfields -ID:/msys64/mingw32/include/gstreamer-1.0 -ID:/msys64/mingw32/include/glib-2.0 -ID:/msys64/mingw32/lib/glib-2.0/include -ID:/msys64/mingw32/include -pthread -mms-bitfields -ID:/msys64/mingw32/include/gstreamer-1.0 -ID:/msys64/mingw32/include/glib-2.0 -ID:/msys64/mingw32/lib/glib-2.0/include -ID:/msys64/mingw32/include -DGST_USE_UNSTABLE_API -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -g -DGST_DISABLE_DEPRECATED -D_FORTIFY_SOURCE=2 -D__USE_MINGW_ANSI_STDIO=1 -I/mingw32/include -march=i686 -mtune=generic -O2 -pipe -MT libgstdecklink_la-gstdecklink.lo -MD -MP -MF .deps/libgstdecklink_la-gstdecklink.Tpo -c ../../../gst-plugins-bad/sys/decklink/gstdecklink.cpp  -DDLL_EXPORT -DPIC -o .libs/libgstdecklink_la-gstdecklink.o
In file included from ../../../gst-plugins-bad/sys/decklink/gstdecklink.h:35:0,
                 from ../../../gst-plugins-bad/sys/decklink/gstdecklink.cpp:27:
../../../gst-plugins-bad/sys/decklink/win/DeckLinkAPI.h:19:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning( disable: 4049 )  /* more than 64k source lines */

In file included from ../../../gst-plugins-bad/sys/decklink/gstdecklink.h:37:0,
                 from ../../../gst-plugins-bad/sys/decklink/gstdecklink.cpp:27:
D:/msys64/mingw32/i686-w64-mingw32/include/comdef.h: In member function 'const TCHAR* _com_error::ErrorMessage() const':
D:/msys64/mingw32/i686-w64-mingw32/include/comdef.h:143:4: error: 'sprintf_s' was not declared in this scope
    _COM_PRINTF_S_1(m_pszMsg,32,TEXT("IDispatch error #%d"),wCode);
    ^
D:/msys64/mingw32/i686-w64-mingw32/include/comdef.h:143:4: note: suggested alternative: 'wsprintfW'
D:/msys64/mingw32/i686-w64-mingw32/include/comdef.h:145:4: error: 'sprintf_s' was not declared in this scope
    _COM_PRINTF_S_1(m_pszMsg,32,TEXT("Unknown error 0x%0lX"),m_hresult);
    ^
...



Workaround is to configure with --disable-decklink.

This is a mingw bug: https://sourceforge.net/p/mingw-w64/bugs/525/

What's confusing is this only happens in mingw32, and works in mingw64.

I'll try with mingw64 and will report back.

The CI was showing a different cross-mingw32-only failure: https://ci.gstreamer.net/job/cerbero-cross-mingw32/6407/console

I fixed that with: https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=0084bfccc9d7d3ef3980bf942ce24bc83648b62a

Can you please use the latest git master in your tests?

Warnings are gone but I still see the error (both with mingw32 and mingw64).

libtool: compile:  x86_64-w64-mingw32-g++ -DHAVE_CONFIG_H -I. -I../../../gst-plugins-bad/sys/decklink -I../.. -I../../../gst-plugins-bad/gst-libs -I../../gst-libs -pthread -mms-bitfields -ID:/msys64/mingw64/include/gstreamer-1.0 -ID:/msys64/mingw64/include/glib-2.0 -ID:/msys64/mingw64/lib/glib-2.0/include -ID:/msys64/mingw64/include -pthread -mms-bitfields -ID:/msys64/mingw64/include/gstreamer-1.0 -ID:/msys64/mingw64/include/glib-2.0 -ID:/msys64/mingw64/lib/glib-2.0/include -ID:/msys64/mingw64/include -pthread -mms-bitfields -ID:/msys64/mingw64/include/gstreamer-1.0 -ID:/msys64/mingw64/include/glib-2.0 -ID:/msys64/mingw64/lib/glib-2.0/include -ID:/msys64/mingw64/include -DGST_USE_UNSTABLE_API -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -g -DGST_DISABLE_DEPRECATED -D_FORTIFY_SOURCE=2 -D__USE_MINGW_ANSI_STDIO=1 -I/mingw64/include -march=x86-64 -mtune=generic -O2 -pipe -MT libgstdecklink_la-gstdecklink.lo -MD -MP -MF .deps/libgstdecklink_la-gstdecklink.Tpo -c ../../../gst-plugins-bad/sys/decklink/gstdecklink.cpp  -DDLL_EXPORT -DPIC -o .libs/libgstdecklink_la-gstdecklink.o
In file included from ../../../gst-plugins-bad/sys/decklink/gstdecklink.h:35:0,
                 from ../../../gst-plugins-bad/sys/decklink/gstdecklink.cpp:27:
../../../gst-plugins-bad/sys/decklink/win/DeckLinkAPI.h:19:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning( disable: 4049 )  /* more than 64k source lines */

In file included from ../../../gst-plugins-bad/sys/decklink/gstdecklink.h:37:0,
                 from ../../../gst-plugins-bad/sys/decklink/gstdecklink.cpp:27:
D:/msys64/mingw64/x86_64-w64-mingw32/include/comdef.h: In member function 'const TCHAR* _com_error::ErrorMessage() const':
D:/msys64/mingw64/x86_64-w64-mingw32/include/comdef.h:143:4: error: 'sprintf_s' was not declared in this scope
    _COM_PRINTF_S_1(m_pszMsg,32,TEXT("IDispatch error #%d"),wCode);
    ^
D:/msys64/mingw64/x86_64-w64-mingw32/include/comdef.h:143:4: note: suggested alternative: 'wsprintfW'
D:/msys64/mingw64/x86_64-w64-mingw32/include/comdef.h:145:4: error: 'sprintf_s' was not declared in this scope
    _COM_PRINTF_S_1(m_pszMsg,32,TEXT("Unknown error 0x%0lX"),m_hresult);
    ^
D:/msys64/mingw64/x86_64-w64-mingw32/include/comdef.h:145:4: note: suggested alternative: 'wsprintfW'



But note that this is an msys2 build so comes, I believe, with its own set of windows headers. I am not yet familiar on how msys2 and mingw articulate.

Will try to look into it. I have searched all good/bad/ugly plugins to see if another plugin was also including comutil.h, but none do : so no working example of using that header.

Offending part in comutil.h :

/* Use of wsprintf might be impossible, if strsafe.h is included. */
#ifndef __STDC_SECURE_LIB__
#define _COM_PRINTF_S_1(dest,destsize,format,arg1) wsprintf(dest,format,arg1)
#elif defined(UNICODE)
#define _COM_PRINTF_S_1(dest,destsize,format,arg1) swprintf_s(dest,destsize,format,arg1)
#else
#define _COM_PRINTF_S_1(dest,destsize,format,arg1) sprintf_s(dest,destsize,format,arg1)
#endif

Adding #include <stdio.h> before #include <comutil.h> in gstdecklink.h and
changing line DECKLINK_LIBS="-loleaut32" to DECKLINK_LIBS="-lole32 -loleaut32" in the root configure.ac file allows the build to complete.


$ gst-inspect-1.0.exe decklink
Plugin Details:
  Name                     decklink
  Description              Blackmagic Decklink plugin
  Filename                 D:\msys64\mingw64\lib\gstreamer-1.0\libgstdecklink.dll
  Version                  1.13.0.1
  License                  LGPL
  Source module            gst-plugins-bad
  Source release date      2017-07-19 15:31 (UTC)
  Binary package           GStreamer Bad Plug-ins
  Origin URL               Unknown package origin

  decklinkvideosrc: Decklink Video Source
  decklinkaudiosrc: Decklink Audio Source
  decklinkvideosink: Decklink Video Sink
  decklinkaudiosink: Decklink Audio Sink

  4 features:
  +-- 4 elements

Thanks! I've tested your changes on cross-mingw and pushed. Closing.

Sorry, forgot to mention a last issue.

The following line in ./win/DeckLinkAPI.h 

  #pragma warning( disable: 4049 )  /* more than 64k source lines */

fails with msys2/mingw/gcc.

I think that #pragma is specific to MSVC and should be #ifdef'ed as such.