After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784927 - 64bit-portability-issues detected
64bit-portability-issues detected
Status: RESOLVED OBSOLETE
Product: vala
Classification: Core
Component: general
0.41.x
Other Linux
: Normal critical
: 0.42
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-13 21:06 UTC by Bjørn Lie
Modified: 2018-05-22 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
codegen: Use g_value_*_pointer for nullable ValueType (3.96 KB, patch)
2017-07-14 08:08 UTC, Rico Tzschichholz
none Details | Review
libvaladoc: Avoid nullable enum as property-type (8.86 KB, patch)
2017-07-17 09:18 UTC, Rico Tzschichholz
committed Details | Review

Description Bjørn Lie 2017-07-13 21:06:53 UTC
When building new 0.37.1 unstable release, our post build checker complains about 64bit-portability-issues in the following files:

[   63s] E: vala 64bit-portability-issue content/embedded.c:613, 616
[   63s] E: vala 64bit-portability-issue content/paragraph.c:416, 419
[   63s] E: vala 64bit-portability-issue content/sourcecode.c:1588
[   63s] E: vala 64bit-portability-issue content/tablecell.c:485, 488
Comment 1 Rico Tzschichholz 2017-07-14 08:08:08 UTC
Created attachment 355568 [details] [review]
codegen: Use g_value_*_pointer for nullable ValueType
Comment 2 Rico Tzschichholz 2017-07-17 09:18:53 UTC
Created attachment 355742 [details] [review]
libvaladoc: Avoid nullable enum as property-type
Comment 3 Rico Tzschichholz 2017-07-17 09:20:43 UTC
Comment on attachment 355742 [details] [review]
libvaladoc: Avoid nullable enum as property-type

Attachment 355742 [details] pushed as 93c41d6 - libvaladoc: Avoid nullable enum as property-type
Comment 4 Dominique Leuenberger 2017-07-20 10:23:43 UTC
Confirmed the BRP checks are passing with attachment 355742 [details] [review] added to the package.
Comment 5 Rico Tzschichholz 2018-03-22 17:38:09 UTC
Review of attachment 355568 [details] [review]:

This issue need to be take care in some way.

Applying this unconditionally obviously changes ABI for projects using such typed properties.

Should there be some feature compile flag to opt-in?
Comment 6 GNOME Infrastructure Team 2018-05-22 15:50:48 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vala/issues/590.