GNOME Bugzilla – Bug 784921
Remove X-GNOME-Bugzilla stuff
Last modified: 2017-09-30 10:25:17 UTC
Created attachment 355544 [details] [review] Generate desktop file from a template Currently desktop file is translated and then, some more fields are inserted into the same file. This patch removes those fields that actually belong to the file, from the Makefile, that should only have build information, and enables autotools to manage automatically the variable substitution.
Review of attachment 355544 [details] [review]: The X-GNOME-Bugzilla stuff is Bugbuddy cruft, which was our bug reporting tool in the GNOME 2 era. It should be removed.
Created attachment 360586 [details] [review] Remove X-GNOME-Bugzilla stuff (In reply to Michael Catanzaro from comment #1) > Review of attachment 355544 [details] [review] [review]: > > The X-GNOME-Bugzilla stuff is Bugbuddy cruft, which was our bug reporting > tool in the GNOME 2 era. It should be removed. Thank you for pointing me this. I remmeber the tool, but I wasn't aware that it didn't exist/wasn't used anymore. I have updated the patch which now removes all that stuff and removes the variable substitution of the input file process.
(From my phone) Need to readd the translators comment from https://git.gnome.org/browse/dconf-editor/commit/editor/?id=74f8e199a1f601cdff2d5788c2ab345f0f7031bb
Created attachment 360693 [details] [review] Remove X-GNOME-Bugzilla stuff (In reply to Arnaud B. from comment #3) > (From my phone) > > Need to readd the translators comment from > https://git.gnome.org/browse/dconf-editor/commit/editor/ > ?id=74f8e199a1f601cdff2d5788c2ab345f0f7031bb You are right, thank you for noticing it. The comment has been added now :) BTW, have you been able to review dconf's/dconf-editor's meson ports?
(From my computer, with a working build, yeah!) (In reply to Iñigo Martínez from comment #4) > You are right, thank you for noticing it. The comment has been added now :) Pushed, thanks. As you’ve maybe understood reading the commit I pointed, this weird construction was the simplest way I’ve found to save the X-GNOME-Bugzilla thing (why not?), that was until then generating a broken .desktop file due to the “@VERSION@” in the .desktop.in file. But with the various changes of the platform, it’s probably better to just remove all these things. > BTW, have you been able to review dconf's/dconf-editor's meson ports? I didn’t work on the ‘dconf’ module, so I’ll only talk for the ‘dconf-editor’ one. My workflow is to answer when I’ve (finally) found the time to do something, so no, sorry. ^^’ I have now my tools back to do a release, but not sure this patch will go inside, it’s a quite big change; I’m more of replacing definitively Autotools in the next release, after giving me the time to test completely.
(In reply to Arnaud B. from comment #5) > (From my computer, with a working build, yeah!) Nice to see you back! :) > I didn’t work on the ‘dconf’ module, so I’ll only talk for the > ‘dconf-editor’ one. My workflow is to answer when I’ve (finally) found the > time to do something, so no, sorry. ^^’ I have now my tools back to do a > release, but not sure this patch will go inside, it’s a quite big change; > I’m more of replacing definitively Autotools in the next release, after > giving me the time to test completely. Yes, changing the build system is quite an important change, though `dconf-edtior`'s meson port is rather small. Do not hesitate to contact me if you need any assistance with or any explanation about it.