After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784882 - common: set "tablet" device type flag for x11 GDK_SOURCE_TABLET_PAD devices
common: set "tablet" device type flag for x11 GDK_SOURCE_TABLET_PAD devices
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-12 22:23 UTC by Carlos Garnacho
Modified: 2017-07-13 16:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
common: Add tablet device type to pad GdkDevices (1.15 KB, patch)
2017-07-12 22:24 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2017-07-12 22:23:54 UTC 
The wacom panel expects the "tablet" device type flag set on all tablet devices. GTK+ correctly started using GDK_SOURCE_TABLET_PAD devices for pad devices, which ironically uncovered a bug in GsdDeviceManager x11 code that would not set that flag. The end result is that pads aren't correctly paired with styli anymore, so tablets lack the "Map buttons..." button.

Attaching a patch for that. It should also be pushed to g-s-d for consistency, since this is shared code.
Comment 1 Carlos Garnacho 2017-07-12 22:24:26 UTC 
Created attachment 355469 [details] [review]
common: Add tablet device type to pad GdkDevices

The wacom panel expects all tablet devices to have the "tablet"
device type flag set on the GsdDevice, otherwise devices won't get
recognized and paired with the other devices for the same tablet.
Uncovered now that GTK+ correctly uses GDK_SOURCE_TABLET_PAD for
pad devices on X11.
Comment 2 Rui Matos 2017-07-13 09:37:30 UTC 
Review of attachment 355469 [details] [review]:

sure
Comment 3 Carlos Garnacho 2017-07-13 16:31:10 UTC 
Thanks! Turns out the common code had additional changes on both
places... I've ended up having to sync both-ways. The g-c-c changes
were more numerous and didn't seem strictly needed for g-s-d, so
I've just pushed the sync to master branches, please shout it you
think synchronizing makes sense for gnome-3-24 too.

Attachment 355469 [details] pushed as 3b72790 - common: Add tablet device type to pad GdkDevices