GNOME Bugzilla – Bug 784817
[review] lr/connectivity-per-af: Do connectivity checking per address family
Last modified: 2020-11-12 14:31:56 UTC
https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=lr/connectivity-per-af
> connectivity: use separate IPv4 and IPv6 connection checks case NM_DEVICE_STATE_ACTIVATED: _LOGI (LOGD_DEVICE, "Activation: successful, device activated."); + + update_connectivity_state (self, AF_INET, NM_CONNECTIVITY_UNKNOWN); + update_connectivity_state (self, AF_INET6, NM_CONNECTIVITY_UNKNOWN); I think this will set IPv4 and IPv6 connectivity immediately to FULL before performing the connectivity check. In the journal I see: connectivity: (ens3) sending request to 'http://fedoraproject.org/static/hotspot.txt' connectivity: (ens3) sending request to 'http://fedoraproject.org/static/hotspot.txt' ... connectivity: (ens3) check successful. connectivity: (ens3) check successful. Maybe add a @family member to ConCheckCbData and print also the family in log messages? > introspection/device: export Ip[46]Connectivity properties + The result of the last connectivity check using IPv4 no this device. + See "Connectivity" property of the "/org/freedesktop/NetworkManager" object + for more details.. s/no/on/ double ending period. The same for IPv6. > dispatcher: indicate the connectivity state per device and AF + if (connectivity_state4 && strcmp(connectivity_state4, "UNKNOWN")) + items = g_slist_prepend (items, g_strdup_printf ("IP4_CONNECTIVITY_STATE=%s", connectivity_state)); Missing space after strcmp. s/connectivity_state/connectivity_state4/ + if (connectivity_state6 && strcmp(connectivity_state6, "UNKNOWN")) + items = g_slist_prepend (items, g_strdup_printf ("IP6_CONNECTIVITY_STATE=%s", connectivity_state)); Ditto.
bugzilla.gnome.org is being shut down in favor of a GitLab instance. We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time. If you still use NetworkManager and if you still see this bug / want this feature in a recent and supported version of NetworkManager, then please feel free to report it at https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/ Thank you for creating this report and we are sorry it could not be implemented (workforce and time is unfortunately limited).