After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784720 - bluetooth: Center empty states in the panel
bluetooth: Center empty states in the panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Bluetooth
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-09 14:12 UTC by Miguel Vaello Martínez
Modified: 2017-07-12 00:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bluetooth: Center empty states in the panel (2.31 KB, patch)
2017-07-09 14:12 UTC, Miguel Vaello Martínez 		none Details | Review
bluetooth: Center empty states in the panel (1.91 KB, patch)
2017-07-12 00:03 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Miguel Vaello Martínez 2017-07-09 14:12:51 UTC 
I have crafted a patch for fix, in my opinion, an annoying thing in the alternative version in the Bluetooth panel. 

The empty states are vertically aligned filling th page, this is not a bad thing for the old version but in the newer alt version is a bit annoying in terms of design when you maximizes the screen. 

I think that the attached patch covers all possible cases but I'm not completly sure.

Thanks.
Comment 1 Miguel Vaello Martínez 2017-07-09 14:12:56 UTC 
Created attachment 355210 [details] [review]
bluetooth: Center empty states in the panel

For the new or alternative version of Control Center, the Bluetooth
empty state will be vertically alligned to the center for any
app window size. Otherwise when the Bluetooh is powered and available,
the align will be as always.

This changes do not affect to the old version because the windows
size (for the old version) is always the same and small
enought to be in the center in any case.
Comment 2 Georges Basile Stavracas Neto 2017-07-11 23:55:40 UTC 
Review of attachment 355210 [details] [review]:

This patch can be simplified by factoring out into a single call to "gtk_widget_set_valign()" after the if()s, and using a "GtkAlign valign" variable
Comment 3 Georges Basile Stavracas Neto 2017-07-12 00:03:38 UTC 
Created attachment 355362 [details] [review]
bluetooth: Center empty states in the panel

Apply the changes
Comment 4 Georges Basile Stavracas Neto 2017-07-12 00:04:07 UTC 
Attachment 355362 [details] pushed as 88b6561 - bluetooth: Center empty states in the panel