GNOME Bugzilla – Bug 784683
gstgdkpixbufdec: stop pretending to decode gifs.
Last modified: 2017-10-16 12:16:45 UTC
If you can't decode an animated gif, you can't decode a gif, so stop squatting GST_RANK_SECONDARY for that format, libav does a better job.
Created attachment 355135 [details] [review] gstgdkpixbufdec: stop pretending to decode gifs.
Review of attachment 355135 [details] [review]: You should probably comment it out like image/jpeg. I guess we should also add on our todo list to have a non-ffmpeg gif decoder because of the licensing problems with ffmpeg.
See https://bugzilla.gnome.org/show_bug.cgi?id=737339 for a non-ffmpeg gif decoder, and was closed by Mathieu as WONTFIX a while ago
(In reply to Sebastian Dröge (slomo) from comment #3) > See https://bugzilla.gnome.org/show_bug.cgi?id=737339 for a non-ffmpeg gif > decoder, and was closed by Mathieu as WONTFIX a while ago It was closed because it was basically a dysfunctional copy paste from ffmpeg, not advertised as such.
Created attachment 361444 [details] [review] gstgdkpixbufdec: stop pretending to decode gifs. If you can't decode an animated gif, you can't decode a gif, so stop squatting GST_RANK_SECONDARY for that format, libav does a better job.
> I guess we should also add on our todo list to have a non-ffmpeg gif decoder > because of the licensing problems with ffmpeg. We may have a rust gif decoder at some point :) https://github.com/sdroege/gst-plugin-rs/issues/11
Review of attachment 361444 [details] [review]: Sounds right to me.
Attachment 361444 [details] pushed as c7a1725 - gstgdkpixbufdec: stop pretending to decode gifs.