After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784666 - videorate: flush remaining buffers on SEGMENT_DONE
videorate: flush remaining buffers on SEGMENT_DONE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 781041 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-07-07 18:46 UTC by Mathieu Duponchelle
Modified: 2017-07-21 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videorate: flush remaining buffers on SEGMENT_DONE (1.09 KB, patch)
2017-07-07 18:46 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-07-07 18:46:04 UTC 
Just as we do on EOS.
Comment 1 Mathieu Duponchelle 2017-07-07 18:46:09 UTC 
Created attachment 355115 [details] [review]
videorate: flush remaining buffers on SEGMENT_DONE
Comment 2 Nicolas Dufresne (ndufresne) 2017-07-07 19:22:05 UTC 
Review of attachment 355115 [details] [review]:

Make sense.
Comment 3 Olivier Crête 2017-07-09 16:25:10 UTC 
Why do that? After a segment done, shouldn't we expect more buffers from the next segment?
Comment 4 Mathieu Duponchelle 2017-07-09 16:59:26 UTC 
(In reply to Olivier Crête from comment #3)
> Why do that? After a segment done, shouldn't we expect more buffers from the
> next segment?

There may not be a next segment :)
Comment 5 Nicolas Dufresne (ndufresne) 2017-07-09 21:27:57 UTC 
And I suppose his bug is about draining and not flushing ?
Comment 6 Sebastian Dröge (slomo) 2017-07-10 06:40:52 UTC 
For all practical purposes, SEGMENT_DONE is like EOS except that you accept further buffers afterwards without having to flush first. So this change seems correct.
Comment 7 Edward Hervey 2017-07-17 14:49:07 UTC 
*** Bug 781041 has been marked as a duplicate of this bug. ***
Comment 8 Nicolas Dufresne (ndufresne) 2017-07-21 18:23:33 UTC 
Thanks.

Attachment 355115 [details] pushed as 875af55 - videorate: flush remaining buffers on SEGMENT_DONE