After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784402 - Use clutter API to handle mapping mode on x11 tablets
Use clutter API to handle mapping mode on x11 tablets
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-30 19:48 UTC by Carlos Garnacho
Modified: 2017-07-12 21:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clutter: Extend mapping-mode to pen/eraser devices (2.20 KB, patch)
2017-06-30 19:49 UTC, Carlos Garnacho 		committed Details | Review
backend: Set mapping-mode on X11 pen/eraser devices (2.07 KB, patch)
2017-06-30 19:49 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2017-06-30 19:48:17 UTC 
Just a low hanging improvement I found during the last round of wacom patches, x11 could be more consistent with wayland here, I'm attaching a couple of patches to do that.
Comment 1 Carlos Garnacho 2017-06-30 19:49:22 UTC 
Created attachment 354750 [details] [review]
clutter: Extend mapping-mode to pen/eraser devices

This just used to apply to CLUTTER_TABLET_DEVICE on wayland, allow using
it on pen/eraser devices (as X11 sees tablets) for consistency.
Comment 2 Carlos Garnacho 2017-06-30 19:49:29 UTC 
Created attachment 354751 [details] [review]
backend: Set mapping-mode on X11 pen/eraser devices

And use it in the generic code for the checks about whether mapping to
an specific display applies or not.
Comment 3 Rui Matos 2017-07-07 12:15:45 UTC 
Review of attachment 354750 [details] [review]:

ok
Comment 4 Rui Matos 2017-07-07 12:25:20 UTC 
Review of attachment 354751 [details] [review]:

seems fine
Comment 5 Carlos Garnacho 2017-07-12 21:52:56 UTC 
Pushed, thanks! Would be nice to move all the configuration stuff to either
clutter/clutter or src/backends, someday... :).

Attachment 354750 [details] pushed as 328e3f8 - clutter: Extend mapping-mode to pen/eraser devices
Attachment 354751 [details] pushed as 10b30ea - backend: Set mapping-mode on X11 pen/eraser devices