After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784189 - Fix meson build error in finding libm library
Fix meson build error in finding libm library
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: general
3.26.x
Other Linux
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 781092 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-06-25 20:51 UTC by Nelson Benitez
Modified: 2021-06-18 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix finding libm library in meson.build (808 bytes, patch)
2017-06-25 20:51 UTC, Nelson Benitez
reviewed Details | Review

Description Nelson Benitez 2017-06-25 20:51:01 UTC
Created attachment 354426 [details] [review]
Fix finding libm library in meson.build

Currently on Fedora 26 beta, trying to JHBuild nautilus fails on configure with following meson error:

Meson encountered an error in file meson.build, line 56, column 0:
C library 'libm' not found


I'm attaching a patch that fixes this build problem. The fix just uses the same invocation for finding libm as used in libgd/meson.build, see:

[nelson@fedora26 nautilus]$ grep -r -n --color=auto --include=*.build -e "libm ="
subprojects/libgd/meson.build:15:libm = cc.find_library('m', required: false)
Comment 1 Nelson Benitez 2017-06-25 20:57:59 UTC
*** Bug 781092 has been marked as a duplicate of this bug. ***
Comment 2 Ernestas Kulik 2017-06-26 06:58:46 UTC
Review of attachment 354426 [details] [review]:

Sure, just update the commit message with an explanation and link to this bug.
Comment 3 Carlos Soriano 2017-06-26 07:00:58 UTC
Review of attachment 354426 [details] [review]:

Why is this necessary? I still don't get it. It's required in Linux platforms, as libm is standalone. (http://mesonbuild.com/howtox.html has an example with libm portability_
Comment 4 Ernestas Kulik 2017-06-26 07:30:17 UTC
(In reply to Carlos Soriano from comment #3)
> Review of attachment 354426 [details] [review] [review]:
> 
> Why is this necessary? I still don't get it. It's required in Linux
> platforms, as libm is standalone. (http://mesonbuild.com/howtox.html has an
> example with libm portability_

Supposedly the C library defines those symbols without a separate math library in cases like this. I’ve tried doing some research, but couldn’t find anything, so I trust that other developers know it better (there is a libgd commit with just this change).
Comment 5 Carlos Soriano 2017-06-26 07:50:25 UTC
(In reply to Ernestas Kulik from comment #4)
> (In reply to Carlos Soriano from comment #3)
> > Review of attachment 354426 [details] [review] [review] [review]:
> > 
> > Why is this necessary? I still don't get it. It's required in Linux
> > platforms, as libm is standalone. (http://mesonbuild.com/howtox.html has an
> > example with libm portability_
> 
> Supposedly the C library defines those symbols without a separate math
> library in cases like this. I’ve tried doing some research, but couldn’t
> find anything, so I trust that other developers know it better (there is a
> libgd commit with just this change).

libgd being in other platforms is expected, since gtk+ is. But not Nautilus. I would prefer to find the root of the problem...
Comment 6 André Klapper 2021-06-18 15:53:29 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Files (nautilus), then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/nautilus/-/issues/

Thank you for your understanding and your help.