After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783823 - Access to NULL ClutterEffect when closing popup in apps view
Access to NULL ClutterEffect when closing popup in apps view
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-15 12:59 UTC by Mario Sánchez Prada
Modified: 2017-06-15 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appDisplay: Add a null-check for the scrollview's fade ClutterEffect (1.59 KB, patch)
2017-06-15 12:59 UTC, Mario Sánchez Prada 		accepted-commit_now Details | Review

Description Mario Sánchez Prada 2017-06-15 12:59:04 UTC 
The vertical fade ClutterEffect referenced from [1] will only exist when the StScrollView actor has either a non-zero vertical or horizontal fade offset defined, which might not be the case depending on the available space in the screen, causing gjs to throw a backtrace when that's not the case (e.g. non-zero offsets not defined for the scrollview via CSS).

I'd suggest adding a simple null-check for the scrollview's to prevent that

[1] https://git.gnome.org/browse/gnome-shell/tree/js/ui/appDisplay.js#n661
Comment 1 Mario Sánchez Prada 2017-06-15 12:59:59 UTC 
Created attachment 353820 [details] [review]
appDisplay: Add a null-check for the scrollview's fade ClutterEffect
Comment 2 Florian Müllner 2017-06-15 13:10:48 UTC 
Review of attachment 353820 [details] [review]:

This was already ACN'ed on IRC ...