GNOME Bugzilla – Bug 783680
Allow to hide color models in GimpColorScales
Last modified: 2018-03-19 22:13:07 UTC
Created attachment 353599 [details] Color box comparison You can see GIMP2.9.x improved color box color layout, white in the upper left corner, which is well suited to the mainstream graphics software. Because GIMP 2.9.x joined the LCH color adjustment, resulting in the vertical space of the color dialog box becomes very large! At GIMP 2.8.x, the color box can be a square. There is no new color dialog does not matter, but whether you can hide unwanted color adjustments? (Although this is not a Bug.) I have been using this GIMP default color box.
I don't get it. What is about this bug report about? Is it about the white vs black on corner? Hasn't there been another bug report about this? Is it about the fact that the color dock is now much too big? If that is the case, I agree. I can't use the dock anymore on my 1366x768 screen without the GIMP window to pass over the screen size, so I have to detach the dock for this not to happen. That's not a joke. We should definitely do something about this point.
See Bug 773461 Comment 16.
(In reply to Jehan from comment #1) > I don't get it. What is about this bug report about? > > Is it about the white vs black on corner? Hasn't there been another bug > report about this? > > Is it about the fact that the color dock is now much too big? If that is the > case, I agree. I can't use the dock anymore on my 1366x768 screen without > the GIMP window to pass over the screen size, so I have to detach the dock > for this not to happen. That's not a joke. > We should definitely do something about this point. White position is the advantage ~ ha ha! (White: I'm a nice guy) The problem is that the vertical size is too large. -------------------- (In reply to Elle Stone from comment #2) > See Bug 773461 Comment 16. OK
(In reply to Jehan from comment #1) > I don't get it. What is about this bug report about? @SenlinOS: It might be helpful if bug reports contained three separate sections: Steps to reproduce; Actual Outcome; Expected Outcome. To avoid misunderstandings like Jehan's. :)
If this is about hiding color scales that are no needed/wanted, the current git master is not the final state of this dialog for 2.10.x, we are going to have some way of hiding stuff.
Should we close as duplicate of bug 773461 then? This is where the "hiding stuff" part will be dealt with, right?
Oh, I totally forgot about that one, let's rather keep this one open as a bug about this specific issue, and close the other one.
Setting this to Major. It definitely has to be fixed for 2.10. This makes the dock unusable unless detached because the GUI is pushed out of the screen. That's just terrible design. :-)
It's no design at all, it's temporary :) I have a start of a patch for a dropdown menu to select what is shown.
Hey thanks for setting to blocker. I hesitate to do so because that's not a crash and didn't want to be too pushy. :P But yeah that's definitely a blocker to me too!
I used bug 770054 to track my progress and forgot about this one. The code is not finished, but the issue here is already fixed: commit 6258d525ae6a099eb1f0ba4d436a30200c49165d Author: Michael Natterer <mitch@gimp.org> Date: Sun Dec 31 17:53:13 2017 +0100 Bug 770054 - High bit-depth color selection widgets This is WIP in the middle of cleaning up GimpColorSelector subclasses: Add the possibility to switch between LCH and LSV and between 0..100 and 0..255 RGB in to GimpColorScales. Works almost fine, but needs different UI to change the options... libgimpwidgets/gimpcolorscales.c | 619 +++++++++++++++++++++++++++++------- libgimpwidgets/gimpcolorscales.h | 10 +- 2 files changed, 521 insertions(+), 108 deletions(-)
Mitch, I don't understand. Did you not mix up the reports? This is not fixed at all. The FG/BG dialog is still huge as shit. Or are you saying that it is going to be fixed as part of bug 770054?
Re：@Jehan Because PPA didn't update the GIMP 2.9.x of the ubuntu 16.04 system, I couldn't see the latest effect. Reason: the (H, S, V, R, G, B, L, C, H)buttons on the right side, which make the panel size bigger. They make the panel unable to shrink.
(In reply to SenlinOS from comment #13) > Reason: the (H, S, V, R, G, B, L, C, H)buttons on the right side, which make > the panel size bigger. > They make the panel unable to shrink. Yes I agree and that is not fixed in master as well. So I am guessing there may be a misunderstanding from Mitch. I will reopen. Mitch, if I was the one to misunderstand, and you were actually meaning you *will* fix this as part of bug 770054, then please, feel free to close again.
I didn't mix up the reports, I simply didn't notice/remember the buttons in the color dockable. Needs to be fixed.
Created attachment 367104 [details] new_FGBG dialog To make the FG/BG dialog to shrink,, It is necessary to separate the color sliders. The width of the color sliders also seems to interfere with the shrink of the dialog box. Attachment, I made a design.
Hi! Mitch > From your last message, I assumed that meant you haven't started working on it, so I just decided to fix this (I tried to get a hold of you on IRC yesterday to make sure I am not invalidating some WIP of yours, but hey… you were the one not available this time ;p). I hope that's ok! So I am reorganizing the channels under color models (something similar to comment 16 proposition except I use a notebook). I applied the same concept on both GimpColorSelect and GimpColorScales using the new "model-changed" signal. That even makes the various color docks in sync with each other (like if you work in LCH in the color scales, switching to the default color dock, you are also in LCH). commit 37e9be3a4f07da1b1410749fec309bd040a8941c Author: Jehan <jehan@girinstud.io> Date: Sun Jan 21 00:35:32 2018 +0100 libgimpwidgets: arrange color models in tabs in GimpColorScales. This allows to have a smaller and cleaner color dock instead of just listing all possible channels (which may only grow up as we may add more color spaces). The API gimp_color_scales_(set|get)_show_hsv() are removed in favor of more generic gimp_color_selector_(set|get)_model(). I assume this is ok since they have only been available in the dev version (commit 6258d525ae, a month ago). libgimpwidgets/gimpcolorscales.c | 230 ++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------- libgimpwidgets/gimpcolorscales.h | 4 -- libgimpwidgets/gimpcolorselector.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- libgimpwidgets/gimpcolorselector.h | 9 +++++ libgimpwidgets/gimpwidgets.def | 4 +- libgimpwidgets/gimpwidgetsenums.c | 32 +++++++++++++++ libgimpwidgets/gimpwidgetsenums.h | 19 +++++++++ 7 files changed, 284 insertions(+), 134 deletions(-) commit 4d84925db09aff638980c093d47cec2deeae33fa (HEAD -> master, origin/master, origin/HEAD) Author: Jehan <jehan@girinstud.io> Date: Sun Jan 21 01:51:18 2018 +0100 Bug 783680 - Allow to hide color models in GimpColorScales. GimpColorSelect now using color models tabs too. libgimpwidgets/gimpcolorselect.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 139 insertions(+), 45 deletions(-)
Hmm, maybe for people with a small screens this latest code is a good thing. But for my particular way of using the FG/BG dialogs, all this new code accomplishes is making it very difficult to pick colors. Let's say I want to pick a particular LCH color. I have in mind a given hue and Lightness and I want the maximum possible Chroma, with a bit of latitude in terms of moving hue, Chroma, and Lightness around as required to make the resulting color not have any out of display range RGB values. With the new dialog, I can only see RGB *OR* LCH. So I switch to LCH and then click on the "Hue" slider, which shows the "left side square of color" with hues in the vertical slider. This is the "left side square of color" that I find most useful. So I use the "left side square" to move the color to "max Chroma" at the point of the "not out of display range" colors. But I can't really tell if the picked color is out of display range or not as the square is small. For this I have to click back to see the RGB slider values. And then if I make an adjustment to the RGB sliders, I have to click back to LCH, at which point I'm no longer looking at the LCH "h" square, but again back at the "L" square, which isn't the square I really want to be looking at. I would request to pretty please restore the UI that Mitch had coded up, before this last commit was made. Or perhaps make a user option in Preferences.
Yea, this is not quite what I had in mind. RGB always needs to be visible. Also, notebooks in norebooks are evil...
Hmmm… ok. Then Mitch, I guess you'll do the deed?
Wait, just to be sure. We agree that the seeing RGB + something-else idea applies only to the GimpColorScales GUI, not the GimpColorSelect one, at least, right? In GimpColorSelect, the GUI simply does not allow to see both RGB + some other color model, so I assume my changes are good there at least, right? If you want, I could also revert only GimpColorScales to something which looks like the old GUI (but still using the concept of color model, I hope at least this implementation concept was ok).
Yes, the color model addition is great, the API being only on GimpColorScales was really a quick hack, it had to be moved to the parent class anyway.
It doesn't seem to satisfy everyone >_< OK~ It may be the best decision to make an independent dialog for GimpColorScales! At the same time you can see the GimpColorSelect and GimpColorScales dialogs. Dialogs can be combined, suitable for large screen and small screen users. GimpColorSelect can also be scaled at will. It's just a suggestion!
Created attachment 367197 [details] dual-pane "Colors" panel Hmm, between GimpColorScales and GimpColorSelect, I'm not sure which dialog is which. In the user interface, there is the dockable "Colors" ("Windows/Dockable dialogs/Colors"). Then there is "Show foreground & background color" which is "Foreground and background colors" in the Toolbox. Personally of the two, I'd prefer to use the "Colors" docker, but I don't because it doesn't allow to show the RGB/LCH sliders and also the rectangular "color box" (that has the vertical slider to one side), both at the same time. Instead these are split into separate panels. If there were a panel in the "Colors" docker that showed both the sliders and the rectangular "color box" at the same time, I'd use the "Colors" docker all the time, and I'd never put "Foreground and background colors" in the Toolbox. The attached png shows a fairly narrow "two-pane" arrangement for the "Colors" dialog. It's just a thought, maybe this would still be too wide.
> Hmm, between GimpColorScales and GimpColorSelect, I'm not sure which dialog is which. "Scales" is the one with sliders. Select is the default one (using Wilber icon). > The attached png shows a fairly narrow "two-pane" arrangement for the "Colors" dialog. It's just a thought, maybe this would still be too wide. Your design is interesting and could be experimented with. But I don't think we should go into too heavy changes so close to 2.10. Maybe later for 2.10.x or 3.0, we could experiment in order to merge the GUIs. Actually I was also wondering if the CMYK as a separate GUI makes sense too. Couldn't it be an additonal model available in the Scales GUI as well? (not the Select GUI though, since it is clearly made to represent 3 axis. Unless we make a 4 axis variant with 2 big 2-axis rectangles)
Created attachment 367218 [details] Current color picking dialogs Hmm, the attached png shows the two dialogs that allow to pick colors as of this morning's code (commit 13b640f84c). Neither dialog allows to show all of the following items all at once: * The RGB sliders * The LCH sliders * The "h" rectangular box in the LCH color model, with the vertical hue slider narrow rectangle and the larger Lightness/Chroma rectangle. For my own editing purposes, I can revert the patch that modified the "Change Foreground Color" dialog (the dialog accessible via the Toolbox icon) to not show both RGB and LCH at the same time. But I'm curious as to whether this is a temporary or permanent omission of the previous ability to show RGB and LCH sliders at the same time, and also whether this is even the right bug report for comments (er, complaints :) ) about changes to the "Change Foreground Color" dialog.
> But I'm curious as to whether this is a temporary or permanent omission of the previous ability to show RGB and LCH sliders at the same time This was my error, I didn't get the needs right, and therefore is temporary (at least in the scales GUI, the one with sliders). I thought it was clear since Mitch's comment 19. :p By the way, I rethought of your need for a colors dock with both the Select and Scales GUI (i.e. the color box and the sliders). You could open the color dock twice (one with each GUI), and have them side by side. Well that requires a big enough screen to not be bothersome and several parts of the docks would be redundant. But that's a possibility for now.
(In reply to Elle Stone from comment #26) > But I'm curious as to whether this is even the right > bug report for comments (er, complaints :) ) > about changes to the "Change Foreground Color" dialog. Actually you are right. For your ideas on merging the Select and Scales GUI for color, could you make a separate bug report? Let's focus here on getting smaller docks while not breaking workflow as I did (so yes, you'll get back RGB+LCH as you wish in the color view with sliders).
This should fix it. Not the perfect GUI, but that can be improved: commit 8447e775ab5165e1bce87addbb48f332bde349f7 Author: Michael Natterer <mitch@gimp.org> Date: Mon Mar 19 22:58:03 2018 +0100 Bug 783680 - Allow to hide color models in GimpColorScales Redo the entire thing again: - Rename the values of enum GimpColorSelectorModel to include "MODEL" - Change GimpColorSelector API from set_model() to set_model_visible() so visibility of each model can be toggled individually and is not exclusive any longer - The GUI is back to what it was before, except that the "GIMP" page now honors the model visibility and has a resonable minimum height libgimpwidgets/gimpcolornotebook.c | 64 +++++++++++- libgimpwidgets/gimpcolorscales.c | 209 +++++++++++++++++++++----------------- libgimpwidgets/gimpcolorselect.c | 190 ++++++++++++++-------------------- libgimpwidgets/gimpcolorselection.c | 2 +- libgimpwidgets/gimpcolorselector.c | 190 +++++++++++++++++++++------------- libgimpwidgets/gimpcolorselector.h | 23 +++-- libgimpwidgets/gimpwidgets.def | 5 +- libgimpwidgets/gimpwidgetsenums.c | 12 +-- libgimpwidgets/gimpwidgetsenums.h | 8 +- libgimpwidgets/gimpwidgetsmarshal.list | 3 +- 10 files changed, 403 insertions(+), 303 deletions(-)