Created attachment 353568 [details] [review]
Generate a gstreamer pipeline diagram on SIGHUP

Add an implementation to do this.

Review of attachment 353568 [details] [review]:

Looks good. Would you like to add some documentation along with this to docs/gst/running.xml ?

I went hunting for the place to write these docs and struggled to find them - can you confirm where the man page is generated?

You'll find the documentation that goes into devhelp and the website in

  docs/gst/running.xml

And the man page is at:

  tools/gst-launch-1.0.1

Created attachment 353714 [details] [review]
Generate a gstreamer pipeline diagram on SIGHUP (with docs and man page)

Updated patch with docs as requested.

Thanks!

Pushed this with minor modification to the print message, and added a message when not dumping the dot file, since it's a bit confusing otherwise.

commit cfe59c285c411a246c8bf8b64e95118fc97a77fe
Author: Graham Leggett <minfrin@sharp.fm>
Date:   Sun Jun 11 15:15:13 2017 +0000

    Generate a gstreamer pipeline diagram on SIGHUP.
    
    Useful for debugging a pipeline that refuses to enter a given state.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=783661

msys2 has build errors because of this change:

../../gstreamer/tools/gst-launch.c:499:1: error: 'hup_handler' defined but not used [-Werror=unused-function]
 hup_handler (gpointer user_data)
 ^~~~~~~~~~~
../../gstreamer/tools/gst-launch.c:471:14: error: 'signal_watch_hup_id' defined but not used [-Werror=unused-variable]
 static guint signal_watch_hup_id;
              ^~~~~~~~~~~~~~~~~~~

workaround : configure with --disable-fatal-warnings

I'll have a look, thanks.

Created attachment 356055 [details] [review]
gst-launch: fix compiler warnings for SIGHUP handlers on windows

Philippe, could you try this patch for me please?

Builds fine with the patch applied.