Created attachment 353239 [details] [review]
adaptivedemux: Answer duration queries for live streams

Some adaptive implementations might only return the actual duration
for live streams via the _get_live_seek_range() method.

Review of attachment 353239 [details] [review]:

Looks good

Comment on attachment 353239 [details] [review]
adaptivedemux: Answer duration queries for live streams

After further discussions in #gstreamer, it seems this might not be the right behaviour.

Since the stream is live, the duration is not defined and therefore one shouldn't return a duration for live streams.

That being said, when one does a duration query on the pipeline, the pipeline still returns a (bogus) duration via the basesink (which returns the current segment.duration).

Maybe we should remove the duration field from the outgoing segments ?

(In reply to Edward Hervey from comment #3)
> Comment on attachment 353239 [details] [review] [review]
> adaptivedemux: Answer duration queries for live streams
> 
> After further discussions in #gstreamer, it seems this might not be the
> right behaviour.
> 
> Since the stream is live, the duration is not defined and therefore one
> shouldn't return a duration for live streams.

Is that so? Maybe should be documented in docs/design :)

> That being said, when one does a duration query on the pipeline, the
> pipeline still returns a (bogus) duration via the basesink (which returns
> the current segment.duration).
> 
> Maybe we should remove the duration field from the outgoing segments ?

Yes (for live streams). Who sets it currently? adaptivedemux?

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/566.