GNOME Bugzilla – Bug 783445
Incomplete documentation of gtk_widget_insert_after/before()
Last modified: 2017-06-06 13:00:49 UTC
The documentation of gtk_widget_insert_after() and gtk_widget_insert_before() does not start with /** and the function name. Therefore the documentation is not extracted by gtk-doc, and it's not automatically included in the documentation of the C++ binding, gtkmm. Is this deliberate? Some parameter names differ between documentation and code. A non-related documentation question: gtk_widget_set_focus_child() is declared in gtkwidget.h. gtk_widget_get_focus_child() is declared in gtkwidgetprivate.h. None of these functions is documented in gtkwidget.c. Are both functions in fact private? Or is gtk_widget_set_focus_child() meant to be used by language bindings and applications?
Created attachment 353208 [details] [review] widget: Fix gtk_widget_insert_after/before() docs
(In reply to Kjell Ahlstedt from comment #0) > Is this deliberate? Nope. > A non-related documentation question: > gtk_widget_set_focus_child() is declared in gtkwidget.h. > gtk_widget_get_focus_child() is declared in gtkwidgetprivate.h. > None of these functions is documented in gtkwidget.c. Are both functions in > fact > private? Or is gtk_widget_set_focus_child() meant to be used by language > bindings and applications? The transition of the focus handling to GtkWidget is not entirely done; i.e. GtkContainer had the adjustment handling and focus chains, but GtkWidget does not have that yet, even though it can have a focus child now. Nobody has come up with a solution for those problems yet though. The gtk_container_ variants should be virtually unused inside gtk+. So, it's not exactly on purpose, but it's on purpose unfinished.
Review of attachment 353208 [details] [review]: LGTM