GNOME Bugzilla – Bug 783429
3.26 redesign: subpanel pages aren't automatically focused
Last modified: 2017-07-25 01:26:20 UTC
gnome-control-center master built in jhbuild on Ubuntu GNOME 17.04 Details and Devices are the two section of gnome-control-center-alt that have subpages. When I click either Details or Devices, I expect the subpanel page to show up. What currently happens is that a page is selected on the left but the right content area still shows whatever older page was selected before clicking Details or Devices.
Created attachment 355617 [details] [review] shell/alt: Always activate panel list after view change The displayed panel should always match the selection in the panel list. That implies that after swapping out the list (for instance by browsing Devices or Details), we need to update the panel rather than keeping the old one around until the user manually selects a row. The easiest way to achieve that is to activate the panel list after a view change when appropriate.
Review of attachment 355617 [details] [review]: This patch causes a crash when opening a panel from the command line. E.g." $ shell/gnome-control-center-alt keyboard"
Created attachment 356328 [details] [review] shell/alt: Always activate panel list after view change The displayed panel should always match the selection in the panel list. That implies that after swapping out the list (for instance by browsing Devices or Details), we need to update the panel rather than keeping the old one around until the user manually selects a row. The easiest way to achieve that is to activate the panel list after a view change when appropriate.
Comment on attachment 356328 [details] [review] shell/alt: Always activate panel list after view change Fixed the crash by keeping track of when we want to autoselect the first panel or not. When setting programatically, don't autoselect; otherwise, do it.
Thanks for the patch. Attachment 356328 [details] pushed as 8b09079 - shell/alt: Always activate panel list after view change