Created attachment 352856 [details] [review]
Revert "password: visibly warn the user when the password is bad"

This reverts commit 3049f2cc46e014aa7cac46a89ac94561c4249ced.

This was introduced when password strength check was not mandatory.

Created attachment 352857 [details] [review]
password: Remove unused password hints

Short password hints are not used for some time. Let's remove them.

Created attachment 352858 [details] [review]
password: Add strength indicator level for weak passwords

Add first level for short, or weak passwords to be obvious that
the strength indicator signalize something.

Created attachment 352859 [details] [review]
password: Improve password hints

Don't say "Good password!" for all acceptable password (e.g. weak passwords).
Say explicitely that password needs to be longer for short passwords.

Created attachment 352860 [details] [review]
password: Change colors of password strength indicator

Use red-yellow- green colors for strength indicator levels.

Review of attachment 352856 [details] [review]:

ok

Review of attachment 352857 [details] [review]:

sure

Review of attachment 352858 [details] [review]:

looks good

Review of attachment 352859 [details] [review]:

++

Review of attachment 352860 [details] [review]:

looks fine, thanks!

Attachment 352856 [details] pushed as 0c62c71 - Revert "password: visibly warn the user when the password is bad"
Attachment 352857 [details] pushed as 68cc39d - password: Remove unused password hints
Attachment 352858 [details] pushed as 2ca5f06 - password: Add strength indicator level for weak passwords
Attachment 352859 [details] pushed as 584a59d - password: Improve password hints
Attachment 352860 [details] pushed as 8d73189 - password: Change colors of password strength indicator

Desynced a bit again, see https://bugzilla.gnome.org/show_bug.cgi?id=754213#c9 for details.