After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783009 - Don't reload transit route result when not changing the mode parameters
Don't reload transit route result when not changing the mode parameters
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-23 17:24 UTC by Marcus Lundblad
Modified: 2017-05-30 20:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
transitOptions: Add function to test two objects for equality (1.38 KB, patch)
2017-05-24 21:15 UTC, Marcus Lundblad
committed Details | Review
transitOptionsPanel: Don't update when options are not changed (1.44 KB, patch)
2017-05-24 21:15 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-05-23 17:24:56 UTC
Currently, when the user opens the popover to select which modes of transit to use after dismissing it we always re-create the options object and reload the query. This means that just clicking on the button and making no changes will reload the result list, which can annoying, especially if the user has loaded more results, as these will be lost. Maybe we should not update if no change was made?
Comment 1 Marcus Lundblad 2017-05-24 21:15:03 UTC
Created attachment 352537 [details] [review]
transitOptions: Add function to test two objects for equality

Add a function to test if two TransitOption objects are equal.
Either if both are set to accept any type, or if they contain the same
set of types, consider them equal, otherwise not.
Comment 2 Marcus Lundblad 2017-05-24 21:15:32 UTC
Created attachment 352538 [details] [review]
transitOptionsPanel: Don't update when options are not changed

Don't update the route query when opening the options popover,
but not changing any preferred modes of transit.
Comment 3 Marcus Lundblad 2017-05-30 20:55:38 UTC
Attachment 352537 [details] pushed as 2357178 - transitOptions: Add function to test two objects for equality
Attachment 352538 [details] pushed as dbab2f6 - transitOptionsPanel: Don't update when options are not changed