GNOME Bugzilla – Bug 782968
size-change signal is not emitted when tiling
Last modified: 2017-05-24 07:52:31 UTC
The signal emission is required in order to animate the tiling action (see bug 766685).
Created attachment 352381 [details] [review] window: Notify about size-change when tiling
Review of attachment 352381 [details] [review]: This seems reasonable to me, but it needs a commit message, describing the change, including the reason why 'tiling' should be considered a 'maximize' change. ::: src/core/window.c @@ +2904,3 @@ meta_screen_update_tile_preview (window->screen, FALSE); + MetaRectangle old_frame_rect, old_buffer_rect; style nit: Variable declarations on top
Created attachment 352430 [details] [review] window: Notify about size-change when tiling Call meta_compositor_size_change_window while tiling in order to emit the size-change signal. Since the untiling action is considered a unmaximize size change, treat tiling as a maximize size change for consistency.
Review of attachment 352430 [details] [review]: lgtm.
Attachment 352430 [details] pushed as 270da95 - window: Notify about size-change when tiling