After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782837 - Untranslated notification
Untranslated notification
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2017-05-19 14:19 UTC by Piotr Drąg
Modified: 2017-09-01 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the issue (12.61 KB, image/png)
2017-05-19 14:19 UTC, Piotr Drąg 		  Details
use gi18n-lib.h (832 bytes, patch)
2017-08-31 23:14 UTC, Sebastien Bacher 		committed Details | Review

Description Piotr Drąg 2017-05-19 14:19:25 UTC 
Created attachment 352160 [details]
Screenshot of the issue

The notification I get after receiving a file is in English.

https://git.gnome.org/browse/gnome-bluetooth/tree/lib/bluetooth-settings-obexpush.c#n145
Comment 1 Bastien Nocera 2017-05-20 07:37:48 UTC 
From a quick look, I have no idea what the problem is, except, possibly, a bug in another library we link to that'd break the text domain.
Comment 2 Sebastien Bacher 2017-08-31 23:14:13 UTC 
Created attachment 358902 [details] [review]
use gi18n-lib.h

the issue is that bluetooth-settings-obexpush.c includes <glib/gi18n.h> and not <glib/gi18n-lib.h>, the -lib version makes _() maps to g_dgettext() which specify the library domain so client binaries don't look for the strings in their own domain
Comment 3 Bastien Nocera 2017-08-31 23:50:50 UTC 
Review of attachment 358902 [details] [review]:

Good catch! Can you please ask for a freeze break and also push to the gnome-3-20 branch (which is used for 3.22 and 3.24 as well)?
Comment 4 Bastien Nocera 2017-09-01 00:04:44 UTC 
Review of attachment 358902 [details] [review]:

Never mind, hard code freeze isn't on yet.
Comment 5 Sebastien Bacher 2017-09-01 07:02:42 UTC 
Review of attachment 358902 [details] [review]:

commit to trunk in a70bacea9
Comment 6 Sebastien Bacher 2017-09-01 07:03:09 UTC 
backported to gnome-3-20 as well