After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782824 - ui: Allow to add games manually
ui: Allow to add games manually
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-19 08:25 UTC by Adrien Plazas
Modified: 2017-07-14 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
preferences: Add the Plugins tab (7.18 KB, patch)
2017-05-19 09:58 UTC, Adrien Plazas
rejected Details | Review
preferences: Remove the Plugins button (4.45 KB, patch)
2017-05-19 09:58 UTC, Adrien Plazas
rejected Details | Review
core: Add GameCollection.get_accepted_mime_types() (993 bytes, patch)
2017-05-21 13:50 UTC, Adrien Plazas
committed Details | Review
ui: Add the 'add-game-files' action (1.98 KB, patch)
2017-05-21 13:50 UTC, Adrien Plazas
committed Details | Review
ui: Add a "Add game files" button (1.92 KB, patch)
2017-05-21 13:50 UTC, Adrien Plazas
committed Details | Review
ui: Make "Add games" dialog buttons translatable (951 bytes, patch)
2017-05-22 08:58 UTC, Adrien Plazas
committed Details | Review
core: Make GameCollection private (810 bytes, patch)
2017-07-14 12:03 UTC, Adrien Plazas
committed Details | Review
build: Add sqlite3 dependency (970 bytes, patch)
2017-07-14 12:03 UTC, Adrien Plazas
committed Details | Review
Add the database module (5.73 KB, patch)
2017-07-14 12:03 UTC, Adrien Plazas
committed Details | Review
ui: Save user game URIs in the database (2.70 KB, patch)
2017-07-14 12:03 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2017-05-19 08:25:33 UTC
Many users complained of games not being found, this is caused by Tracker not being installed on the machine of by it not tracking the game files for some reason.

To solve that, I suggest we let the users manually add games via an "Add game" button on the collection's header bar and by saving URIs of games passed to the command line.
Comment 1 Adrien Plazas 2017-05-19 08:29:37 UTC
Once such a way to add games is added, the empty state page should state it. Also once all of this done, Games can be added here: https://wiki.gnome.org/Newcomers/ChooseProject.
Comment 2 Adrien Plazas 2017-05-19 09:58:49 UTC
Created attachment 352146 [details] [review]
preferences: Add the Plugins tab
Comment 3 Adrien Plazas 2017-05-19 09:58:55 UTC
Created attachment 352147 [details] [review]
preferences: Remove the Plugins button
Comment 4 Adrien Plazas 2017-05-21 13:50:36 UTC
Created attachment 352282 [details] [review]
core: Add GameCollection.get_accepted_mime_types()

This will be used in the next commit to filter files in a game file
chooser.
Comment 5 Adrien Plazas 2017-05-21 13:50:43 UTC
Created attachment 352283 [details] [review]
ui: Add the 'add-game-files' action

The action will be used in the next commit to triggers a game file
chooser, letting the user select files to add to the games collection.
Comment 6 Adrien Plazas 2017-05-21 13:50:49 UTC
Created attachment 352284 [details] [review]
ui: Add a "Add game files" button

This button is added to the collection header bar.

This allows to add games to the collection from files.
Comment 7 Abhinav Singh 2017-05-21 14:31:12 UTC
Review of attachment 352284 [details] [review]:

Just a minor error. LGTM otherwise.

::: data/ui/collection-header-bar.ui
@@ +21,3 @@
+        </child>
+        <child>
+          <class name="image-button"/>

image name is not correct
Comment 8 Adrien Plazas 2017-05-21 14:51:40 UTC
Attachment 352282 [details] pushed as 5c5a9e8 - core: Add GameCollection.get_accepted_mime_types()
Attachment 352283 [details] pushed as c75aafd - ui: Add the 'add-game-files' action
Attachment 352284 [details] pushed as f4d7475 - ui: Add a "Add game files" button
Comment 9 Piotr Drąg 2017-05-21 15:03:53 UTC
"_Cancel" and "_Add" buttons in commit c75aafdeb35eaa239a8a1b544a54e434914e21a5 are not marked for translation.
Comment 10 Adrien Plazas 2017-05-22 08:58:10 UTC
Created attachment 352345 [details] [review]
ui: Make "Add games" dialog buttons translatable
Comment 11 Adrien Plazas 2017-05-22 09:00:39 UTC
Thanks Piotr.
Comment 12 Adrien Plazas 2017-05-22 09:01:05 UTC
Comment on attachment 352345 [details] [review]
ui: Make "Add games" dialog buttons translatable

Attachment 352345 [details] pushed as 0c18c2c - ui: Make "Add games" dialog buttons translatable
Comment 13 Adrien Plazas 2017-07-14 12:03:35 UTC
Created attachment 355590 [details] [review]
core: Make GameCollection private

There is no need for it to be public.
Comment 14 Adrien Plazas 2017-07-14 12:03:40 UTC
Created attachment 355591 [details] [review]
build: Add sqlite3 dependency

This will be used in the next commits by the database module.
Comment 15 Adrien Plazas 2017-07-14 12:03:45 UTC
Created attachment 355592 [details] [review]
Add the database module

This will be used in the next commit to store game URIs added by the
user.
Comment 16 Adrien Plazas 2017-07-14 12:03:50 UTC
Created attachment 355593 [details] [review]
ui: Save user game URIs in the database

Store the URIs given by the user via the command line or the "Add games"
button so they can be restored when restarting the application.
Comment 17 Adrien Plazas 2017-07-14 12:05:59 UTC
Attachment 355590 [details] pushed as 815f084 - core: Make GameCollection private
Attachment 355591 [details] pushed as 002cab8 - build: Add sqlite3 dependency
Attachment 355592 [details] pushed as de38e53 - Add the database module
Attachment 355593 [details] pushed as 0524c14 - ui: Save user game URIs in the database