After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782543 - vaapisink: disabled event thread when PLAYING->NULL->PLAYING
vaapisink: disabled event thread when PLAYING->NULL->PLAYING
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.12.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-12 06:41 UTC by Hyunjun Ko
Modified: 2017-05-12 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapisink: keep handle_events flag except that if user want to set (3.26 KB, patch)
2017-05-12 06:42 UTC, Hyunjun Ko 		none Details | Review
vaapisink: keep handle_events flag except that if user want to set (1.30 KB, patch)
2017-05-12 11:04 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2017-05-12 06:41:07 UTC 
When state of vaapisink is changed from PLAYING to NULL,
the handle_events flag is set to FALSE, and never recovered,
and then event thread is never going to run.
Comment 1 Hyunjun Ko 2017-05-12 06:42:07 UTC 
Created attachment 351698 [details] [review]
vaapisink: keep handle_events flag except that if user  want to set

When state of vaapisink is changed from PLAYING to NULL,
the handle_events flag is set to FALSE, and never recovered,
and then event thread is never going to run.

So we should allow to set the flag only when users try it.
Comment 2 Víctor Manuel Jáquez Leal 2017-05-12 10:51:08 UTC 
Review of attachment 351698 [details] [review]:

This patch can be simplified a two-liner patch: only set sink->handler_event at the function gst_vaapisink_video_overlay_set_event_handling(), and delete the setting in gst_vaapisink_set_event_handling(). The rest remains as is.
Comment 3 Víctor Manuel Jáquez Leal 2017-05-12 10:51:09 UTC 
Review of attachment 351698 [details] [review]:

This patch can be simplified a two-liner patch: only set sink->handler_event at the function gst_vaapisink_video_overlay_set_event_handling(), and delete the setting in gst_vaapisink_set_event_handling(). The rest remains as is.
Comment 4 Hyunjun Ko 2017-05-12 11:04:49 UTC 
Created attachment 351709 [details] [review]
vaapisink: keep handle_events flag except that if user want  to set

When state of vaapisink is changed from PLAYING to NULL,
the handle_events flag is set to FALSE, and never recovered,
and then event thread is never going to run.

So we should allow to set the flag only when users try it.
Comment 5 Víctor Manuel Jáquez Leal 2017-05-12 14:57:35 UTC 
Attachment 351709 [details] pushed as 5ab5113 - vaapisink: keep handle_events flag except that if user want  to set
Comment 6 Víctor Manuel Jáquez Leal 2017-05-12 15:30:53 UTC 
branch 1.10 

1714489c (HEAD -> 1.10, origin/1.10, ceyusa/1.10) vaapisink: keep handle_events flag except that if user want to set
Comment 7 Víctor Manuel Jáquez Leal 2017-05-12 15:34:43 UTC 
branch 1.12

* aaaf8d2b vaapisink: keep handle_events flag except that if user want to set