After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782093 - shout2send: log actual username in debug log
shout2send: log actual username in debug log
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-03 00:43 UTC by Adrián Pardini
Modified: 2018-01-18 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch file implementing the proposed change. (1005 bytes, patch)
2017-05-03 00:43 UTC, Adrián Pardini 		committed Details | Review

Description Adrián Pardini 2017-05-03 00:43:14 UTC 
Created attachment 350914 [details] [review]
Patch file implementing the proposed change.

Just a very minor thing I spotted.

While looking at the code of shout2send in gst_shout2send_start() for all the properties it logs the current value in sink->the_property except 'username'.

I'm not sure if there's a reason for this. The attached patch changes it to match the behavior of the other properties.

Thanks.
Comment 1 Tim-Philipp Müller 2017-05-03 07:54:42 UTC 
True. I wondered if we should put username/password into the log at all, but then I guess it's elsewhere already if it comes from a parse-launch pipeline string.
Comment 2 Tim-Philipp Müller 2018-01-18 18:29:39 UTC 
Pushed, sorry for the delay (and for the confusing extra word in the modified commit message):

commit c0195300919af46964884de6b4bbd5df7fb8c211
Author: Adrián Pardini <github@tangopardo.com.ar>
Date:   Tue May 2 21:24:06 2017 -0300

    shout2send: print actual username in debug log out
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782093
Comment 3 Adrián Pardini 2018-01-18 19:16:54 UTC 
(In reply to Tim-Philipp Müller from comment #2)
> Pushed, sorry for the delay (and for the confusing extra word in the
> modified commit message):

No problem, thanks!