After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782063 - Fix vaapidecodebin classification to be similar as decodebin
Fix vaapidecodebin classification to be similar as decodebin
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
1.11.91
Other Linux
: Normal normal
: 1.12.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-02 12:15 UTC by Victor Toso
Modified: 2017-05-10 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
It changes plugins classification (1.10 KB, patch)
2017-05-02 12:15 UTC, Victor Toso
rejected Details | Review

Description Victor Toso 2017-05-02 12:15:44 UTC
Created attachment 350866 [details] [review]
It changes plugins classification

.
Comment 1 Víctor Manuel Jáquez Leal 2017-05-02 14:36:55 UTC
commit 8cbe03599a4f27c2001380e2ec150c4f4267a9cf
Author: Victor Toso <me@victortoso.com>
Date:   Tue May 2 14:08:54 2017 +0200

    vaapidecodebin: fix element's classification

    This bin should have similar classification as decodebin which is
    "Generic/Bin/Decoder" otherwise it will appear wrongly as video
    decoder.

    Signed-off-by: Victor Toso <victortoso@redhat.com>

    https://bugzilla.gnome.org/show_bug.cgi?id=782063
Comment 2 Víctor Manuel Jáquez Leal 2017-05-04 10:04:56 UTC
I had to revert (in extremis) this patch, since it breaks all the playback with vaapisink.
Comment 3 Víctor Manuel Jáquez Leal 2017-05-04 10:06:16 UTC
Thanks to Hyunjun for notice it, and a big brown bag for me because I didn't reviewed thoroughly.
Comment 4 Victor Toso 2017-05-05 13:54:03 UTC
(In reply to Víctor Manuel Jáquez Leal from comment #3)
> Thanks to Hyunjun for notice it, and a big brown bag for me because I didn't
> reviewed thoroughly.

Sorry about that, I did not notice any issue here.
What would be the right approach for this?
Comment 5 Víctor Manuel Jáquez Leal 2017-05-05 14:16:07 UTC
(In reply to Victor Toso from comment #4)
> (In reply to Víctor Manuel Jáquez Leal from comment #3)
> > Thanks to Hyunjun for notice it, and a big brown bag for me because I didn't
> > reviewed thoroughly.
> 
> Sorry about that, I did not notice any issue here.
> What would be the right approach for this?

Deprecating vaapidecodebin by making decodebin and decodebin3 smart enough to use vaapipostproc when it is neeeded :)
Comment 6 Tim-Philipp Müller 2017-05-08 11:12:06 UTC
What's the actually purpose of this change though?
Comment 7 Víctor Manuel Jáquez Leal 2017-05-10 14:51:49 UTC
(In reply to Tim-Philipp Müller from comment #6)
> What's the actually purpose of this change though?

AFAIK, to place the element in a different classification, just as decodebin. But it is not related to decodebin at all. It is only a general decoder.

Thus I'm closing this bug.