After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782026 - uninstalled: broken on windows
uninstalled: broken on windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-build
1.12.x
Other Windows
: Normal normal
: 1.12.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-01 20:24 UTC by Scott D Phillips
Modified: 2017-05-05 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH gst-build] uninstalled: fixes for windows usage (1.52 KB, patch)
2017-05-01 20:24 UTC, Scott D Phillips
committed Details | Review

Description Scott D Phillips 2017-05-01 20:24:04 UTC
Created attachment 350824 [details] [review]
[PATCH gst-build] uninstalled: fixes for windows usage

* missing sys.executable in a subprocess.check_output()
* os.normpath in a regex expands to '\g' which is invalid in regexes.
Comment 1 Nirbheek Chauhan 2017-05-03 17:16:39 UTC
Review of attachment 350824 [details] [review]:

LGTM!
Comment 2 Nirbheek Chauhan 2017-05-05 10:13:09 UTC
Comment on attachment 350824 [details] [review]
[PATCH gst-build] uninstalled: fixes for windows usage

Pushed to gst-uninstalled master, 1.12 stable branch next
Comment 3 Nirbheek Chauhan 2017-05-05 10:15:28 UTC
All done.