After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782000 - password modal dialog has text flow problems when Large Text is enabled
password modal dialog has text flow problems when Large Text is enabled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-01 00:13 UTC by Chris Murphy
Modified: 2017-05-05 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (39.73 KB, image/png)
2017-05-01 00:13 UTC, Chris Murphy
  Details
theme: Use font-relative width for prompts (1.43 KB, patch)
2017-05-01 10:54 UTC, Florian Müllner
none Details | Review
theme: Use font-relative width for prompts (2.36 KB, patch)
2017-05-04 22:54 UTC, Florian Müllner
committed Details | Review

Description Chris Murphy 2017-05-01 00:13:58 UTC
Created attachment 350777 [details]
screenshot

Summary:
GNOME Terminal or Tilix, ssh to a remote using keys, I get a modal password dialog for the key; and this dialog has visibility problems. Not all of the text is readable.

Reproducible:
Always

Version:
gnome-shell-3.24.1-1.fc26.x86_64

Regression:
No, has been going on for several Fedora releases.

Reproduce steps:
1. Enable Large Text in Universal Access
2. Use ssh and public key authentication (see attached screen shot)

Actual results:

Title statement is cut off at the word privat(e)

Unlock button is hiding a full line of text

Expected results:
Make the dialog bigger so the larger text is completely visible.


Additional info:
Problem doesn't happen by default, requires Large Text to be enabled.
Comment 1 Florian Müllner 2017-05-01 10:54:41 UTC
Created attachment 350795 [details] [review]
theme: Use font-relative width for prompts

The usual expectation when selecting large fonts is for content to
be bigger, not that less content is displayed. While not always
possible, there's no reason not to scale modal dialogues with the
font size.
Comment 2 Rui Matos 2017-05-02 13:21:17 UTC
Review of attachment 350795 [details] [review]:

looks fine.

from a quick look we have the same problem for .nm-dialog and .mount-question-dialog-subject
Comment 3 Florian Müllner 2017-05-04 22:54:46 UTC
Created attachment 351140 [details] [review]
theme: Use font-relative width for prompts

(In reply to Rui Matos from comment #2)
> from a quick look we have the same problem for .nm-dialog and
> .mount-question-dialog-subject

Right. .search-entry might be another candidate, but leaving out non-dialogues for now ...
Comment 4 Rui Matos 2017-05-05 09:13:22 UTC
Review of attachment 351140 [details] [review]:

++
Comment 5 Florian Müllner 2017-05-05 09:29:08 UTC
Attachment 351140 [details] pushed as 2a3a5df - theme: Use font-relative width for prompts