After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781912 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: pybliographer
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Pybliographer maintainer(s)
Pybliographer maintainer(s)
Depends on:
Blocks: 772263
 
 
Reported: 2017-04-28 17:45 UTC by Piotr Drąg
Modified: 2017-10-07 01:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (32.88 KB, patch)
2017-04-28 17:46 UTC, Piotr Drąg
committed Details | Review
Add encoding within the files with utf-8 characters (4.91 KB, patch)
2017-10-07 01:32 UTC, Germán Poo-Caamaño
committed Details | Review

Description Piotr Drąg 2017-04-28 17:45:26 UTC
Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Piotr Drąg 2017-04-28 17:46:27 UTC
Created attachment 350676 [details] [review]
Use Unicode in translatable strings
Comment 2 Germán Poo-Caamaño 2017-04-28 18:18:00 UTC
Thanks Piotr. Did you check whether it works? I have not (yet).

Python 2 can be picky with Unicode, but I may be biased because I am been trying to fix an unicode issue :-)
Comment 3 Piotr Drąg 2017-04-28 18:34:29 UTC
Unfortunately, I don’t have a way to test it. I guess it can wait until you have the time.
Comment 4 Germán Poo-Caamaño 2017-10-07 01:32:59 UTC
Created attachment 361076 [details] [review]
Add encoding within the files with utf-8 characters

We need this patch to make Python happy when finding utf-8
characters in the source code. See PEP 0263:
https://www.python.org/dev/peps/pep-0263/
Comment 5 Germán Poo-Caamaño 2017-10-07 01:34:18 UTC
Review of attachment 361076 [details] [review]:

Thanks!
Committed after adding a the encoding to every affected file
Comment 6 Germán Poo-Caamaño 2017-10-07 01:35:09 UTC
Review of attachment 350676 [details] [review]:

Committed after adding a the encoding to every affected file
Comment 7 Germán Poo-Caamaño 2017-10-07 01:36:41 UTC
I pushed it in master.

It needs some changes to apply it in wip/gtk3.