After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781686 - room: Fix infinite loop with unset nickname
room: Fix infinite loop with unset nickname
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-24 22:47 UTC by Florian Müllner
Modified: 2017-04-24 23:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
room: Fix infinite loop with unset nickname (1004 bytes, patch)
2017-04-24 22:47 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-04-24 22:47:00 UTC
See patch. Reported by Michael on IRC.
Comment 1 Florian Müllner 2017-04-24 22:47:04 UTC
Created attachment 350344 [details] [review]
room: Fix infinite loop with unset nickname

While an empty (self) nick is unexpected, it's apparently possible
under some circumstances. Handle that case explicitly to avoid
entering an infinite loop.
Comment 2 Florian Müllner 2017-04-24 23:45:33 UTC
Attachment 350344 [details] pushed as cea385a - room: Fix infinite loop with unset nickname