GNOME Bugzilla – Bug 781548
Allow switching between native (for instance osxappinfo) and generic (freedesktop-based) appinfo implementation at build time
Last modified: 2018-05-24 19:30:16 UTC
This patchset lets users select the appinfo implementation at build time. The native OS X (appbundle-based) appinfo implementation is not good enough for all cases. Especially when using GTK+ compiled against X11, having the generic appinfo implementation is more useful. Also, I have fixed up installing missing headers for the win32appinfo implementation and made that switchable as well - even though the generic appinfo implementation currently won't work on Windows. The default behavior is retained - by default glib will select the native appinfo implementation as before if the new configure switch is not passed.
No patches ? I think I've outlined my view of this before (maybe in some other bug): I think this is stopgap measure that we should perhaps merge to keep all those rebuilders (brew and friends) from patching glib. But it is really not more than just that: a stopgap. What we need here is to 1) make the implementation of the extension point runtime-selectable 2) support multiple implementations, merging their appinfo sets together. There will be some interesting questions to answer here, like: how to resolve defaults
Created attachment 350155 [details] [review] Appinfo implementation switching
I had to create the bug first to get its ID and reference that in the commit. :)
Yes, runtime selection with multiple implementations would be even better, but as a packager being able to switch implementations via a configure option is much better than patching glib around.
Seems like this will help resolve Bug 780309 also.
Created attachment 371942 [details] [review] Refreshed version of Mihai's patch, now for 2.56.0
Review of attachment 371942 [details] [review]: Can you please rebase this against master and submit it as a git-formatted patch? Anything else makes it harder to deal with the contributions. This will also need equivalent support in the Meson build system, as we’re at a stage where we want feature parity between the two build systems. Thanks.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1263.