After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781545 - extensionPrefs: Avoid a runtime warning
extensionPrefs: Avoid a runtime warning
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-20 15:37 UTC by Florian Müllner
Modified: 2017-04-20 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extensionPrefs: Avoid a runtime warning (2.07 KB, patch)
2017-04-20 15:37 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-04-20 15:37:41 UTC 
See patch.
Comment 1 Florian Müllner 2017-04-20 15:37:48 UTC 
Created attachment 350143 [details] [review]
extensionPrefs: Avoid a runtime warning

Since 5b3fb024be, the main window is only shown when not launched
with a valid UUID. As GtkDialog isn't meant to be used standalone,
we currently trigger a (harmless but annoying) warning in case
the main window isn't shown; we can avoid the warning by setting
up the preference dialog manually instead of using the GtkDialog
convenience class.
Comment 2 Rui Matos 2017-04-20 16:02:47 UTC 
Review of attachment 350143 [details] [review]:

looks fine

::: js/extensionPrefs/main.js
@@ +94,3 @@
         }
 
+        let dialog = new Gtk.Window({ modal: true,

modal could be set only in the !_skipMainWindow path
Comment 3 Florian Müllner 2017-04-20 17:18:54 UTC 
Attachment 350143 [details] pushed as 06fdf2f - extensionPrefs: Avoid a runtime warning