After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781544 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-20 15:33 UTC by Piotr Drąg
Modified: 2017-10-30 18:34 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Use Unicode in translatable strings (2.25 KB, patch)
2017-04-20 15:34 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2017-04-20 15:33:28 UTC 
Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Piotr Drąg 2017-04-20 15:34:13 UTC 
Created attachment 350142 [details] [review]
Use Unicode in translatable strings
Comment 2 Piotr Drąg 2017-10-24 16:22:19 UTC 
Is it OK to push this? We’re still very early in the cycle, so it’s the best time for such changes.
Comment 3 Jonathan Kang 2017-10-25 08:56:29 UTC 
(In reply to Piotr Drąg from comment #2)
> Is it OK to push this? We’re still very early in the cycle, so it’s the best
> time for such changes.

Looks pretty good to me.

Add Isaque to CC list for the review.
Comment 4 Piotr Drąg 2017-10-30 18:30:04 UTC 
Comment on attachment 350142 [details] [review]
Use Unicode in translatable strings

Accepted on IRC.

https://git.gnome.org/browse/bijiben/commit/?id=bf3c4c3bb382f23e6263fb57d0d7350894cf9901

Thank you!
Comment 5 Isaque Galdino 2017-10-30 18:32:36 UTC 
Review of attachment 350142 [details] [review]:

Nice work, thanks for your patch.
Please go ahead and commit it!
Comment 6 Piotr Drąg 2017-10-30 18:34:18 UTC 
Comment on attachment 350142 [details] [review]
Use Unicode in translatable strings

I was faster. :P