After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781266 - qtdemux: Properly reset demuxer when all streams are EOS
qtdemux: Properly reset demuxer when all streams are EOS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-13 11:26 UTC by Edward Hervey
Modified: 2017-04-14 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtdemux: Properly reset demuxer when all streams are EOS (1.99 KB, patch)
2017-04-13 11:26 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2017-04-13 11:26:34 UTC
See commit
Comment 1 Edward Hervey 2017-04-13 11:26:40 UTC
Created attachment 349791 [details] [review]
qtdemux: Properly reset demuxer when all streams are EOS

Make sure offset and neededbytes are properly resetted when all
streams are EOS in push-mode.

Avoids cases when some data might still be pushed by upstream (because
it didn't yet see the resulting GST_FLOW_EOS yet) and qtdemux gets
completely lost.
Comment 2 Edward Hervey 2017-04-14 05:57:26 UTC
commit c6e9c67f63ccb87c61dfc348252ddbfc0866bb0f
Author: Edward Hervey <edward@centricular.com>
Date:   Thu Apr 13 13:25:06 2017 +0200

    qtdemux: Properly reset demuxer when all streams are EOS
    
    Make sure offset and neededbytes are properly resetted when all
    streams are EOS in push-mode.
    
    Avoids cases when some data might still be pushed by upstream (because
    it didn't yet see the resulting GST_FLOW_EOS yet) and qtdemux gets
    completely lost.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781266