After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781178 - line breaks lost when selecting and replying to certain messages
line breaks lost when selecting and replying to certain messages
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
master
Other Linux
: High normal
: 0.12.1
Assigned To: Michael Gratton
Geary Maintainers
wk2-fallout
Depends on:
Blocks:
 
 
Reported: 2017-04-11 12:02 UTC by Federico Bruni
Modified: 2017-12-02 01:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Federico Bruni 2017-04-11 12:02:50 UTC
First reported here:
https://mail.gnome.org/archives/geary-list/2017-March/msg00001.html

As I had no feedback, I'm reporting it here as well.

Steps to reproduce:

- select part of a message where you have a line break
- reply using either a keyboard shortcut or the menu
- RESULT: line break removed in the quoted text

NOTE: I've just realized that it does not occur always. So it might depend on the quoted message. It seems it always happens when I reply to my own messages. Behaviour with other messages changes.

Here's some header information of a message which I can select and reply to correctly:

Content-Type: multipart/alternative; boundary=001a113ebccc09d262054c832638

--001a113ebccc09d262054c832638
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable


And this is the header of a message where I get no line breaks if I select and reply:

Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable

Probably not much helpful.. Let me know how can I provide better information.
Comment 1 Michael Gratton 2017-04-23 07:03:24 UTC
Yep, I've seen it as well, it's is pretty annoying.
Comment 2 Federico Bruni 2017-10-28 21:17:03 UTC
I'm checking again...

It seems that quoted text is not correct when replying to a text only message.
The default mode of Geary composer, plain text or HTML, is not relevant. What matters is the message you are replying to.

Mike, I've just made a test on an email sent by you, which had just these:

Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

and quoted text appears compressed in a single paragraph.

Quoted text appears correct when the messages are a mix of HTML and plain text.
For example, I've just made a test on a message sent by Yahoo mail, which is set up this way:

Content-Type: multipart/alternative; 
	boundary="----=_Part_6368312_1754565969.1508965255048"

------=_Part_6368312_1754565969.1508965255048
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

[here's the plain text]

------=_Part_6368312_1754565969.1508965255048
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html><head></head><body>
[here's the HTML]
Comment 3 Federico Bruni 2017-10-29 17:55:29 UTC
So it looks like '\n' is removed in selected text quoted in the reply (while '<br>' is kept).
Comment 4 Michael Gratton 2017-11-16 07:12:36 UTC
Fix for this and a followup pushed to master as commit c2afe8f and commit 1d746e4. Will bake for a while the cherry pick onto geary-0.12.
Comment 5 Federico Bruni 2017-11-16 08:12:21 UTC
Great! I confirm it works fine again!
Comment 6 Michael Gratton 2017-12-02 01:39:46 UTC
Cherry picked to geary-0.12 as commit db41c30 and commit 0fdbe5d, resolving as fixed.