After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781017 - gstaggregator: fix event use after free
gstaggregator: fix event use after free
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-07 09:22 UTC by Vincent Penquerc'h
Modified: 2017-05-08 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstaggregator: fix event use after free (1.05 KB, patch)
2017-04-07 09:23 UTC, Vincent Penquerc'h 		none Details | Review
gstaggregator: fix event use after free (1.19 KB, patch)
2017-04-07 11:43 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2017-04-07 09:22:18 UTC 
gstaggregator: fix event use after free
Comment 1 Vincent Penquerc'h 2017-04-07 09:23:04 UTC 
Created attachment 349434 [details] [review]
gstaggregator: fix event use after free
Comment 2 Sebastian Dröge (slomo) 2017-04-07 09:56:21 UTC 
Comment on attachment 349434 [details] [review]
gstaggregator: fix event use after free

This seems suspicious. Either it takes ownership of the event, or it doesn't. But it should be consistent.
Comment 3 Vincent Penquerc'h 2017-04-07 11:14:20 UTC 
I'm not clear on whether sink_event should eat the ref in case of failure.
Comment 4 Sebastian Dröge (slomo) 2017-04-07 11:35:06 UTC 
Yes
Comment 5 Vincent Penquerc'h 2017-04-07 11:43:32 UTC 
Created attachment 349460 [details] [review]
gstaggregator: fix event use after free
Comment 6 Vincent Penquerc'h 2017-04-07 11:44:17 UTC 
This version just looks what it needs before calling sink_event, and thus does not need to retain a ref for after the call.
Comment 7 Sebastian Dröge (slomo) 2017-04-07 11:50:13 UTC 
Review of attachment 349460 [details] [review]:

ok :)
Comment 8 Sebastian Dröge (slomo) 2017-04-09 08:18:53 UTC 
Attachment 349460 [details] pushed as cd78fc5 - gstaggregator: fix event use after free